search

keeferrourke / pyapa

A Python module for checking APA style. Not a papaya.
https://pypi.python.org/pypi/pyapa/
ISC License
2 stars 1 forks source link

Email regex allows illegal domains #4

Closed harpunius closed 6 years ago

harpunius commented 7 years ago

The current email regex allows for the following emails, none of which are correct.

x@-.dk x@y-.dk x@-y.dk x@y..dk

I hardly see a point in fixing them, as this is not an email-verifying service - what are your thoughts?

keeferrourke commented 6 years ago

If you want to fix them, go for it, but the "email" pattern is just used to exclude the match from some of the overlapping error patterns. :smile:

keeferrourke commented 6 years ago

I think it's best if this goes unfixed. Even if someone writes an illegal domain in a text file that is being processed by pyapa, I think it's better to have a 'looser' rule here, otherwise more errors may be returned than necessary, possibly with misleading feedback.

harpunius commented 6 years ago

I agree