search

keeganstreet / element-finder

Find in Files with CSS selectors
http://keegan.st/2012/06/03/find-in-files-with-css-selectors/
118 stars 8 forks source link

Replace JSDOM and Sizzle with Cheerio #3

Closed keeganstreet closed 11 years ago

keeganstreet commented 11 years ago

Cheerio runs 6 times faster in my initial tests. It also has fewer dependencies. The dependencies are JavaScript only which means users should have fewer installation problems.

https://github.com/MatthewMueller/cheerio

mennovanslooten commented 11 years ago

I'd also like to see this. I'd love to use elfinder but the JSDOM dependency causes this error: https://github.com/tmpvar/jsdom/issues/436

keeganstreet commented 11 years ago

I have added unit tests to Element Finder so now I'm in a position to add Cheerio in and see if the tests still pass. This one should be resolved soon.

keeganstreet commented 11 years ago

Done! Element Finder 0.2.0 is out and has no jsdom dependency.

mennovanslooten commented 11 years ago

It works! You rock!