search

keel-hq / keel

Kubernetes Operator to automate Helm, DaemonSet, StatefulSet & Deployment updates
https://keel.sh
Mozilla Public License 2.0
2.45k stars 282 forks source link

Error: Record not found on reject - Never query approval again #474

Open rchenzheng opened 4 years ago

rchenzheng commented 4 years ago 
time="2020-01-31T00:55:28Z" level=error msg="bot.processApprovedResponse: failed to reject" error="record not found" identifier=

When rejecting an approval from Slack, it returns record not found and never allows deployments again. I have it setup so it deploys on tag matching and polling digest change, after the first reject it never requests for approvals again. 

      keel.sh/policy: "force"
      keel.sh/trigger: poll
      keel.sh/approvals: "1"
      keel.sh/match-tag: "true"

I expected it to detect a different digest/sha from the new push and query Slack for approvals again

rchenzheng commented 4 years ago

Any updates on this?

dardanbekteshi commented 4 years ago

I experienced the same problem. After I rejected a "staging ---> staging" update, I didn't get a new approval when I pushed a new image with tag "staging".

I am using a polling strategy with Amazon ECR as Docker registry.

dardanbekteshi commented 4 years ago

Update: It seems like it starts to send approvals again once I archived the rejected approval.