keel-hq / keel

Kubernetes Operator to automate Helm, DaemonSet, StatefulSet & Deployment updates
https://keel.sh
Mozilla Public License 2.0
2.45k stars 282 forks source link

Starting with non-semver-tag, Keel is upgrading to any tag #480

Open v-morlock opened 4 years ago

v-morlock commented 4 years ago

When we first setup an environment, we start by deploying a "latest" image. Starting from that, Keel is upgrading to any tag, not only to semver-Tags, e.g. from "latest" to "dev".

We specified the following policy:

      "keel.sh/policy"    = "major"
      "keel.sh/trigger"   = "pubsub"

Am I missing anything here?

rusenask commented 4 years ago

that is strange! it should update to the latest semver from latest, not just any tag. I guess you are using it with polling trigger?

v-morlock commented 4 years ago

Nope, I'm using the gcr pubsub trigger. Lately I also experienced it to show the wrong version as a target, e.g. an image was pushed as image:1.0.1 but keel tried (and failed) to evaluate on just image

Thanks in advance!

rusenask commented 4 years ago

would it be possible for you to get a sample of this gcr message?