keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

View and functionality for adding volume to task (FE) #351

Open MariusJulius opened 1 year ago

MariusJulius commented 1 year ago

Wiki Figma - volume by CAT Figma -volume manually

BE task: #350

To-do:

plakitkelly commented 1 year ago

Adding volume manually works as expected. Adding volume with cat tool is not done yet. Upd: Yes, it's done, but logic is not right. Check my next comment.

MariusJulius commented 1 year ago

Done, but logic needs review, in some cases not shown.

KaarelKa commented 1 year ago

Done, but logic needs review, in some cases not shown.

@MariusJulius Can you elaborate on this a bit ? Are there some cases, where it should not be shown, but is shown right now, or the other way around ?

plakitkelly commented 1 year ago

@KaarelKa Currently it's possible to add volume with cat tool only if task is splitted between atleast 2 vendors. It's not possible to add volume with cat tool when there is only one vendor, because I can't see xliff file there. After assinging one xliff file to both (if 2) vendors, you have to refresh the browser.

Image Image

Image

Image

KaarelKa commented 1 year ago

@MariusJulius FE part is done and should work once restriction is removed from BE: https://pundar.slack.com/archives/C053FD55ATT/p1699602235143569

Not sure if we have a BE task for this yet

MariusJulius commented 11 months ago

Fixed was written in the BE ticket: https://github.com/keeleinstituut/tv-tolkevarav/issues/350

plakitkelly commented 10 months ago

Tested in 17.12 - It's OK