search

keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Vendor view tag and comment field editing bugs (FE) #472

Open MariusJulius opened 1 year ago

MariusJulius commented 1 year ago

Issues:

To-do:

IngaSokman commented 1 year ago

@thenouan I see that BE requires request body (with comment, company name, tags not empty) for the change of the vendor. Currently I cannot change company name without adding a change to comment as well, I cannot change the tags without changing company name and comment as well, I cannot change comment without changing company name as well. I I understand each filed must be changeable at it's own. Could you please look into it?

thenouan commented 1 year ago

@IngaSokman by looking at the code then it seems to be possible. Can you provide some curl examples? With tags we already have another bug task for it

IngaSokman commented 1 year ago

@thenouan Definitely. 1) When adding only company name: curl -X 'PUT' \ 'https://api.dev.tolkevarav.eki.ee/translation-order/api/vendors/9a4b5c13-c2f9-4c26-9fc3-ed0b507a1553' \ -H 'accept: application/json' \ -H 'Authorization: Bearer eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJBRzRYOXR2SVhubkoxWUhiYnJHZmdYdnNYNEVVU2xGalk0RkZSekY5MjlRIn0.eyJleHAiOjE2OTY5MjM3ODIsImlhdCI6MTY5NjkyMDE4MiwiYXV0aF90aW1lIjoxNjk2OTIwMDM3LCJqdGkiOiJlNDQ4MzJjMy02NDU1LTQxMWYtYWJmNC1kYjVkNzE1YWQzN2QiLCJpc3MiOiJodHRwczovL3Nzby5kZXYudG9sa2V2YXJhdi5la2kuZWUvcmVhbG1zL3RvbGtldmFyYXYtZGV2IiwiYXVkIjoiYWNjb3VudCIsInN1YiI6IjY5MmQwYzdlLTQzNTgtNDY5MS1hNTgyLTcwYjY3Zjk3M2JlMiIsInR5cCI6IkJlYXJlciIsImF6cCI6IndlYiIsIm5vbmNlIjoiYTk3ZWJlNTItNmI3YS00ZTUyLTg1YWUtY2ZhMTQ1MDVmOWQzIiwic2Vzc2lvbl9zdGF0ZSI6IjM5MGFhNjZiLTFiMzgtNGM5Zi05YWYwLTQ5NTFiYzU4YmU4NyIsImFjciI6IjAiLCJhbGxvd2VkLW9yaWdpbnMiOlsiKiJdLCJyZWFsbV9hY2Nlc3MiOnsicm9sZXMiOlsib2ZmbGluZV9hY2Nlc3MiLCJkZWZhdWx0LXJvbGVzLXRvbGtldmFyYXYtZGV2IiwidW1hX2F1dGhvcml6YXRpb24iXX0sInJlc291cmNlX2FjY2VzcyI6eyJhY2NvdW50Ijp7InJvbGVzIjpbIm1hbmFnZS1hY2NvdW50IiwibWFuYWdlLWFjY291bnQtbGlua3MiLCJ2aWV3LXByb2ZpbGUiXX19LCJzY29wZSI6Im9wZW5pZCBlbWFpbCBwcm9maWxlIiwic2lkIjoiMzkwYWE2NmItMWIzOC00YzlmLTlhZjAtNDk1MWJjNThiZTg3IiwidG9sa2V2YXJhdiI6eyJwZXJzb25hbElkZW50aWZpY2F0aW9uQ29kZSI6IjM5NjA4MTcyNzY1IiwidXNlcklkIjoiOWExZjUyYTAtNWEwOC00ZWNlLWJiMTAtMWVhNDQ1N2U1MDA3IiwiaW5zdGl0dXRpb25Vc2VySWQiOiI5YTFmNTJhMC01YjE3LTQ5N2YtOTkxOC03NTgxMjczODE4MDkiLCJmb3JlbmFtZSI6Ik1hcmt1cyIsInN1cm5hbWUiOiJQZXRlcnNvbiIsInNlbGVjdGVkSW5zdGl0dXRpb24iOnsiaWQiOiI5YTFmNTI5Yy1jYTgwLTQxZWYtOGVjOS0zM2Q1ZDM5YmJiYjEiLCJuYW1lIjoiT2ZpY2luYSBkZSBJZGlvbWFzIGRlLU1hcnF1aXoifSwicHJpdmlsZWdlcyI6WyJBRERfUk9MRSIsIlZJRVdfUk9MRSIsIkVESVRfUk9MRSIsIkRFTEVURV9ST0xFIiwiQUREX1VTRVIiLCJFRElUX1VTRVIiLCJWSUVXX1VTRVIiLCJFWFBPUlRfVVNFUiIsIkFDVElWQVRFX1VTRVIiLCJERUFDVElWQVRFX1VTRVIiLCJBUkNISVZFX1VTRVIiLCJFRElUX1VTRVJfV09SS1RJTUUiLCJFRElUX1VTRVJfVkFDQVRJT04iLCJBRERfVEFHIiwiRURJVF9UQUciLCJERUxFVEVfVEFHIiwiQUREX0RFUEFSVE1FTlQiLCJFRElUX0RFUEFSVE1FTlQiLCJERUxFVEVfREVQQVJUTUVOVCIsIlZJRVdfVkVORE9SX0RCIiwiRURJVF9WRU5ET1JfREIiLCJWSUVXX0dFTkVSQUxfUFJJQ0VMSVNUIiwiVklFV19WRU5ET1JfVEFTSyIsIkVESVRfSU5TVElUVVRJT04iLCJFRElUX0lOU1RJVFVUSU9OX1dPUktUSU1FIiwiQ1JFQVRFX1BST0pFQ1QiLCJNQU5BR0VfUFJPSkVDVCIsIlJFQ0VJVkVfQU5EX01BTkFHRV9QUk9KRUNUIiwiVklFV19QRVJTT05BTF9QUk9KRUNUIiwiVklFV19JTlNUSVRVVElPTl9QUk9KRUNUX0xJU1QiLCJWSUVXX0lOU1RJVFVUSU9OX1BST0pFQ1RfREVUQUlMIiwiQ0hBTkdFX0NMSUVOVCIsIklNUE9SVF9UTSIsIkNSRUFURV9UTSIsIkVYUE9SVF9UTSIsIkVESVRfVE1fTUVUQURBVEEiLCJFRElUX1RNIiwiREVMRVRFX1RNIiwiVklFV19UTSJdfSwiZW1haWxfdmVyaWZpZWQiOmZhbHNlLCJuYW1lIjoiZWUzOTYwODE3Mjc2NS1maXJzdC1uYW1lIGVlMzk2MDgxNzI3NjUtbGFzdC1uYW1lIiwicHJlZmVycmVkX3VzZXJuYW1lIjoiZWUzOTYwODE3Mjc2NSIsImdpdmVuX25hbWUiOiJlZTM5NjA4MTcyNzY1LWZpcnN0LW5hbWUiLCJmYW1pbHlfbmFtZSI6ImVlMzk2MDgxNzI3NjUtbGFzdC1uYW1lIn0.japXLYgzm5PXreBKtCXdqWSAgIBGAeak8bQ7nPSmyNj-pFYQDpG04GuviTfDrq9ButA6vfLlTTFnPYUljOjQD9RAbnmtZorBlhXK6JW5CMiwMBxKdoVKQI9AhoP1LoExqn9Pyv5UwITU7rBLUsUc9pmdmVLJ58r9aX3UiuH8nalVk7x9obeE8kUAxh-bkjfVXbkBNHtWbGpIrRPf4g6UOrTnUfAk7HjQQdVWhGdbT4lKYF9JGEudtP7dFJuuGLaAfn5FaTN8d7Sj17HjNqEIoI7mJNgqkSw3k87mHw7EDn1gYFkhRhtQ8QvMBEoIv8gHzziXtiKQ__1l9htOMrGw' \ -H 'Content-Type: application/json' \ -H 'X-CSRF-TOKEN: ' \ -d '{ "tags": [], "company_name": "bu", "comment": "", "email": "marius@singleton.ee", "phone": "+37251964076", "discount_percentage_0_49": "0", "discount_percentage_50_74": "0", "discount_percentage_75_84": "0", "discount_percentage_85_94": "0", "discount_percentage_95_99": "0", "discount_percentage_100": "0", "discount_percentage_101": "0", "discount_percentage_repetitions": "0" }'

2) When adding only tag:

curl -X 'PUT' \ 'https://api.dev.tolkevarav.eki.ee/translation-order/api/vendors/9a4b5c13-c2f9-4c26-9fc3-ed0b507a1553' \ -H 'accept: application/json' \ -H 'Authorization: Bearer eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJBRzRYOXR2SVhubkoxWUhiYnJHZmdYdnNYNEVVU2xGalk0RkZSekY5MjlRIn0.eyJleHAiOjE2OTY5MjM3ODIsImlhdCI6MTY5NjkyMDE4MiwiYXV0aF90aW1lIjoxNjk2OTIwMDM3LCJqdGkiOiJlNDQ4MzJjMy02NDU1LTQxMWYtYWJmNC1kYjVkNzE1YWQzN2QiLCJpc3MiOiJodHRwczovL3Nzby5kZXYudG9sa2V2YXJhdi5la2kuZWUvcmVhbG1zL3RvbGtldmFyYXYtZGV2IiwiYXVkIjoiYWNjb3VudCIsInN1YiI6IjY5MmQwYzdlLTQzNTgtNDY5MS1hNTgyLTcwYjY3Zjk3M2JlMiIsInR5cCI6IkJlYXJlciIsImF6cCI6IndlYiIsIm5vbmNlIjoiYTk3ZWJlNTItNmI3YS00ZTUyLTg1YWUtY2ZhMTQ1MDVmOWQzIiwic2Vzc2lvbl9zdGF0ZSI6IjM5MGFhNjZiLTFiMzgtNGM5Zi05YWYwLTQ5NTFiYzU4YmU4NyIsImFjciI6IjAiLCJhbGxvd2VkLW9yaWdpbnMiOlsiKiJdLCJyZWFsbV9hY2Nlc3MiOnsicm9sZXMiOlsib2ZmbGluZV9hY2Nlc3MiLCJkZWZhdWx0LXJvbGVzLXRvbGtldmFyYXYtZGV2IiwidW1hX2F1dGhvcml6YXRpb24iXX0sInJlc291cmNlX2FjY2VzcyI6eyJhY2NvdW50Ijp7InJvbGVzIjpbIm1hbmFnZS1hY2NvdW50IiwibWFuYWdlLWFjY291bnQtbGlua3MiLCJ2aWV3LXByb2ZpbGUiXX19LCJzY29wZSI6Im9wZW5pZCBlbWFpbCBwcm9maWxlIiwic2lkIjoiMzkwYWE2NmItMWIzOC00YzlmLTlhZjAtNDk1MWJjNThiZTg3IiwidG9sa2V2YXJhdiI6eyJwZXJzb25hbElkZW50aWZpY2F0aW9uQ29kZSI6IjM5NjA4MTcyNzY1IiwidXNlcklkIjoiOWExZjUyYTAtNWEwOC00ZWNlLWJiMTAtMWVhNDQ1N2U1MDA3IiwiaW5zdGl0dXRpb25Vc2VySWQiOiI5YTFmNTJhMC01YjE3LTQ5N2YtOTkxOC03NTgxMjczODE4MDkiLCJmb3JlbmFtZSI6Ik1hcmt1cyIsInN1cm5hbWUiOiJQZXRlcnNvbiIsInNlbGVjdGVkSW5zdGl0dXRpb24iOnsiaWQiOiI5YTFmNTI5Yy1jYTgwLTQxZWYtOGVjOS0zM2Q1ZDM5YmJiYjEiLCJuYW1lIjoiT2ZpY2luYSBkZSBJZGlvbWFzIGRlLU1hcnF1aXoifSwicHJpdmlsZWdlcyI6WyJBRERfUk9MRSIsIlZJRVdfUk9MRSIsIkVESVRfUk9MRSIsIkRFTEVURV9ST0xFIiwiQUREX1VTRVIiLCJFRElUX1VTRVIiLCJWSUVXX1VTRVIiLCJFWFBPUlRfVVNFUiIsIkFDVElWQVRFX1VTRVIiLCJERUFDVElWQVRFX1VTRVIiLCJBUkNISVZFX1VTRVIiLCJFRElUX1VTRVJfV09SS1RJTUUiLCJFRElUX1VTRVJfVkFDQVRJT04iLCJBRERfVEFHIiwiRURJVF9UQUciLCJERUxFVEVfVEFHIiwiQUREX0RFUEFSVE1FTlQiLCJFRElUX0RFUEFSVE1FTlQiLCJERUxFVEVfREVQQVJUTUVOVCIsIlZJRVdfVkVORE9SX0RCIiwiRURJVF9WRU5ET1JfREIiLCJWSUVXX0dFTkVSQUxfUFJJQ0VMSVNUIiwiVklFV19WRU5ET1JfVEFTSyIsIkVESVRfSU5TVElUVVRJT04iLCJFRElUX0lOU1RJVFVUSU9OX1dPUktUSU1FIiwiQ1JFQVRFX1BST0pFQ1QiLCJNQU5BR0VfUFJPSkVDVCIsIlJFQ0VJVkVfQU5EX01BTkFHRV9QUk9KRUNUIiwiVklFV19QRVJTT05BTF9QUk9KRUNUIiwiVklFV19JTlNUSVRVVElPTl9QUk9KRUNUX0xJU1QiLCJWSUVXX0lOU1RJVFVUSU9OX1BST0pFQ1RfREVUQUlMIiwiQ0hBTkdFX0NMSUVOVCIsIklNUE9SVF9UTSIsIkNSRUFURV9UTSIsIkVYUE9SVF9UTSIsIkVESVRfVE1fTUVUQURBVEEiLCJFRElUX1RNIiwiREVMRVRFX1RNIiwiVklFV19UTSJdfSwiZW1haWxfdmVyaWZpZWQiOmZhbHNlLCJuYW1lIjoiZWUzOTYwODE3Mjc2NS1maXJzdC1uYW1lIGVlMzk2MDgxNzI3NjUtbGFzdC1uYW1lIiwicHJlZmVycmVkX3VzZXJuYW1lIjoiZWUzOTYwODE3Mjc2NSIsImdpdmVuX25hbWUiOiJlZTM5NjA4MTcyNzY1LWZpcnN0LW5hbWUiLCJmYW1pbHlfbmFtZSI6ImVlMzk2MDgxNzI3NjUtbGFzdC1uYW1lIn0.japXLYgzm5PXreBKtCXdqWSAgIBGAeak8bQ7nPSmyNj-pFYQDpG04GuviTfDrq9ButA6vfLlTTFnPYUljOjQD9RAbnmtZorBlhXK6JW5CMiwMBxKdoVKQI9AhoP1LoExqn9Pyv5UwITU7rBLUsUc9pmdmVLJ58r9aX3UiuH8nalVk7x9obeE8kUAxh-bkjfVXbkBNHtWbGpIrRPf4g6UOrTnUfAk7HjQQdVWhGdbT4lKYF9JGEudtP7dFJuuGLaAfn5FaTN8d7Sj17HjNqEIoI7mJNgqkSw3k87mHw7EDn1gYFkhRhtQ8QvMBEoIv8gHzziXtiKQ__1l9htOMrGw' \ -H 'Content-Type: application/json' \ -H 'X-CSRF-TOKEN: ' \ -d '{ "tags": [ "9a4bd1bd-7353-467c-94a5-63c08e075010" ], "company_name": "", "comment": "", "email": "marius@singleton.ee", "phone": "+37251964076", "discount_percentage_0_49": "0", "discount_percentage_50_74": "0", "discount_percentage_75_84": "0", "discount_percentage_85_94": "0", "discount_percentage_95_99": "0", "discount_percentage_100": "0", "discount_percentage_101": "0", "discount_percentage_repetitions": "0" }'

3) When adding only comment:

curl -X 'PUT' \ 'https://api.dev.tolkevarav.eki.ee/translation-order/api/vendors/9a4b5c13-c2f9-4c26-9fc3-ed0b507a1553' \ -H 'accept: application/json' \ -H 'Authorization: Bearer eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJBRzRYOXR2SVhubkoxWUhiYnJHZmdYdnNYNEVVU2xGalk0RkZSekY5MjlRIn0.eyJleHAiOjE2OTY5MjM3ODIsImlhdCI6MTY5NjkyMDE4MiwiYXV0aF90aW1lIjoxNjk2OTIwMDM3LCJqdGkiOiJlNDQ4MzJjMy02NDU1LTQxMWYtYWJmNC1kYjVkNzE1YWQzN2QiLCJpc3MiOiJodHRwczovL3Nzby5kZXYudG9sa2V2YXJhdi5la2kuZWUvcmVhbG1zL3RvbGtldmFyYXYtZGV2IiwiYXVkIjoiYWNjb3VudCIsInN1YiI6IjY5MmQwYzdlLTQzNTgtNDY5MS1hNTgyLTcwYjY3Zjk3M2JlMiIsInR5cCI6IkJlYXJlciIsImF6cCI6IndlYiIsIm5vbmNlIjoiYTk3ZWJlNTItNmI3YS00ZTUyLTg1YWUtY2ZhMTQ1MDVmOWQzIiwic2Vzc2lvbl9zdGF0ZSI6IjM5MGFhNjZiLTFiMzgtNGM5Zi05YWYwLTQ5NTFiYzU4YmU4NyIsImFjciI6IjAiLCJhbGxvd2VkLW9yaWdpbnMiOlsiKiJdLCJyZWFsbV9hY2Nlc3MiOnsicm9sZXMiOlsib2ZmbGluZV9hY2Nlc3MiLCJkZWZhdWx0LXJvbGVzLXRvbGtldmFyYXYtZGV2IiwidW1hX2F1dGhvcml6YXRpb24iXX0sInJlc291cmNlX2FjY2VzcyI6eyJhY2NvdW50Ijp7InJvbGVzIjpbIm1hbmFnZS1hY2NvdW50IiwibWFuYWdlLWFjY291bnQtbGlua3MiLCJ2aWV3LXByb2ZpbGUiXX19LCJzY29wZSI6Im9wZW5pZCBlbWFpbCBwcm9maWxlIiwic2lkIjoiMzkwYWE2NmItMWIzOC00YzlmLTlhZjAtNDk1MWJjNThiZTg3IiwidG9sa2V2YXJhdiI6eyJwZXJzb25hbElkZW50aWZpY2F0aW9uQ29kZSI6IjM5NjA4MTcyNzY1IiwidXNlcklkIjoiOWExZjUyYTAtNWEwOC00ZWNlLWJiMTAtMWVhNDQ1N2U1MDA3IiwiaW5zdGl0dXRpb25Vc2VySWQiOiI5YTFmNTJhMC01YjE3LTQ5N2YtOTkxOC03NTgxMjczODE4MDkiLCJmb3JlbmFtZSI6Ik1hcmt1cyIsInN1cm5hbWUiOiJQZXRlcnNvbiIsInNlbGVjdGVkSW5zdGl0dXRpb24iOnsiaWQiOiI5YTFmNTI5Yy1jYTgwLTQxZWYtOGVjOS0zM2Q1ZDM5YmJiYjEiLCJuYW1lIjoiT2ZpY2luYSBkZSBJZGlvbWFzIGRlLU1hcnF1aXoifSwicHJpdmlsZWdlcyI6WyJBRERfUk9MRSIsIlZJRVdfUk9MRSIsIkVESVRfUk9MRSIsIkRFTEVURV9ST0xFIiwiQUREX1VTRVIiLCJFRElUX1VTRVIiLCJWSUVXX1VTRVIiLCJFWFBPUlRfVVNFUiIsIkFDVElWQVRFX1VTRVIiLCJERUFDVElWQVRFX1VTRVIiLCJBUkNISVZFX1VTRVIiLCJFRElUX1VTRVJfV09SS1RJTUUiLCJFRElUX1VTRVJfVkFDQVRJT04iLCJBRERfVEFHIiwiRURJVF9UQUciLCJERUxFVEVfVEFHIiwiQUREX0RFUEFSVE1FTlQiLCJFRElUX0RFUEFSVE1FTlQiLCJERUxFVEVfREVQQVJUTUVOVCIsIlZJRVdfVkVORE9SX0RCIiwiRURJVF9WRU5ET1JfREIiLCJWSUVXX0dFTkVSQUxfUFJJQ0VMSVNUIiwiVklFV19WRU5ET1JfVEFTSyIsIkVESVRfSU5TVElUVVRJT04iLCJFRElUX0lOU1RJVFVUSU9OX1dPUktUSU1FIiwiQ1JFQVRFX1BST0pFQ1QiLCJNQU5BR0VfUFJPSkVDVCIsIlJFQ0VJVkVfQU5EX01BTkFHRV9QUk9KRUNUIiwiVklFV19QRVJTT05BTF9QUk9KRUNUIiwiVklFV19JTlNUSVRVVElPTl9QUk9KRUNUX0xJU1QiLCJWSUVXX0lOU1RJVFVUSU9OX1BST0pFQ1RfREVUQUlMIiwiQ0hBTkdFX0NMSUVOVCIsIklNUE9SVF9UTSIsIkNSRUFURV9UTSIsIkVYUE9SVF9UTSIsIkVESVRfVE1fTUVUQURBVEEiLCJFRElUX1RNIiwiREVMRVRFX1RNIiwiVklFV19UTSJdfSwiZW1haWxfdmVyaWZpZWQiOmZhbHNlLCJuYW1lIjoiZWUzOTYwODE3Mjc2NS1maXJzdC1uYW1lIGVlMzk2MDgxNzI3NjUtbGFzdC1uYW1lIiwicHJlZmVycmVkX3VzZXJuYW1lIjoiZWUzOTYwODE3Mjc2NSIsImdpdmVuX25hbWUiOiJlZTM5NjA4MTcyNzY1LWZpcnN0LW5hbWUiLCJmYW1pbHlfbmFtZSI6ImVlMzk2MDgxNzI3NjUtbGFzdC1uYW1lIn0.japXLYgzm5PXreBKtCXdqWSAgIBGAeak8bQ7nPSmyNj-pFYQDpG04GuviTfDrq9ButA6vfLlTTFnPYUljOjQD9RAbnmtZorBlhXK6JW5CMiwMBxKdoVKQI9AhoP1LoExqn9Pyv5UwITU7rBLUsUc9pmdmVLJ58r9aX3UiuH8nalVk7x9obeE8kUAxh-bkjfVXbkBNHtWbGpIrRPf4g6UOrTnUfAk7HjQQdVWhGdbT4lKYF9JGEudtP7dFJuuGLaAfn5FaTN8d7Sj17HjNqEIoI7mJNgqkSw3k87mHw7EDn1gYFkhRhtQ8QvMBEoIv8gHzziXtiKQ__1l9htOMrGw' \ -H 'Content-Type: application/json' \ -H 'X-CSRF-TOKEN: ' \ -d '{ "tags": [], "company_name": "", "comment": "vv", "email": "marius@singleton.ee", "phone": "+37251964076", "discount_percentage_0_49": "0", "discount_percentage_50_74": "0", "discount_percentage_75_84": "0", "discount_percentage_85_94": "0", "discount_percentage_95_99": "0", "discount_percentage_100": "0", "discount_percentage_101": "0", "discount_percentage_repetitions": "0" }'

MariusJulius commented 1 year ago

@thenouan please check Inga example so we could solve this. Not critical but still somewhat bad issue when trying to manage vendors.

MariusJulius commented 11 months ago

@KaarelKa @IngaSokman

KaarelKa commented 11 months ago

@MariusJulius can you retest this, only case I currently noticed was when Lepingupartneri ärinimi was missing, since that field is required

plakitkelly commented 11 months ago

It's OK