keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Rollihaldus improvements and bugs #504

Open plakitkelly opened 11 months ago

plakitkelly commented 11 months ago

Issue 1. (FE) User has add_role and view_role privileges

  1. Click on "Lisa uus roll"
  2. Click outside the "Kirjuta uus roll siia..." field or mark checkboxes

Actual: User cannot add role name for new role after clicking outside the textbox. So, if user have marked many checkboxes before entering role name, user cannot save this anymore and have to start again.

Issue 2. (FE) - Duplicate: https://github.com/keeleinstituut/tv-tolkevarav/issues/407 User has add_role and view_role privileges

  1. Click on "Lisa uus roll"
  2. Enter name or select privileges
  3. Click on "Tühista" button

Actual: Entered role name and selected privileges disappears but there is still new role tab visible. User cannot enter new name for this role anymore (check previous issue). Expected: Wiki 2.1.7 User decides not to save the role and clicks "Cancel" New role is not saved, table remains like before starting the addition of the new role. Added new empty role should disappear then? (by Marius: delete button for removing empty role) - Should fix delete button functionality

issue 3. (FE) Is it possible to make the buttons active immediately after changing the name? If user has edited the name of the role, but has not pressed enter or added privileges, the "Tühista" and "Save" buttons are inactive (but clickable) Video (low?)

issue 4. (BE)

  1. Create role with name "asd"
  2. Create role with name "123"
  3. Change the role asd name to 123 Actual: User sees error - Request failed with status code 500 Expected: Show better error for end-user.
MariusJulius commented 10 months ago

@rebekkabb 1 and 3 can be done.

plakitkelly commented 10 months ago

1 and 3 OK

plakitkelly commented 9 months ago

2 and 4 are not fixed

plakitkelly commented 7 months ago

I will test when 407 fixed