keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Add/edit vendors modal bug #505

Open plakitkelly opened 8 months ago

plakitkelly commented 8 months ago

Wiki Users with status "deactivated" or "archived" should not be displayed in the list.

BE task: https://github.com/keeleinstituut/tv-tolkevarav/issues/633

IngaSokman commented 8 months ago

Currently waiting for BE to be done with api /institution-users filtering by statuses

MariusJulius commented 6 months ago

Inga: Dima did it so that now FE doesn't have to send filters (to show only active users), because now (after Dima's task gets merged) this endpoint returns the right information. At the moment, FE sends an active status filter, but BE does not send the correct information back, because no filtering has been done for this endpoint at all

plakitkelly commented 6 months ago

I have 9 names with Juku in users list. Some of them are deactivated and archived. image

And they all are in vendors list image

KaarelKa commented 6 months ago

@MariusJulius Should be BE issue, if I understood your previous comment correctly

MariusJulius commented 6 months ago

PR with the fix was here: https://github.com/keeleinstituut/tv-authorization/pull/82 but seems not fixed.

KaarelKa commented 6 months ago

Related to #435 and #458

If we will go with just FE passing the filter and hiding it, then I can add the filter back to this modal as well, when doing #435

KaarelKa commented 6 months ago

Suggestion here: Let's solve on FE

MariusJulius commented 6 months ago

Delete other tickets - not relevant to solve.

MariusJulius commented 6 months ago

Kaarel tested ok. It might have been syncing issue during deploy.

KaarelKa commented 6 months ago

Seems to be. Syncing issue yes, but will discuss this with @thenouan a bit, since it seems to happen quite often. Did a few quick tests and it stopped syncing after a couple of updates

MariusJulius commented 6 months ago

duplicate of https://github.com/keeleinstituut/tv-tolkevarav/issues/633