Adding vendor to task table BUGS

plakitkelly commented 1 year ago

User selects one vendor and goes to another page, selected vendor is not selected anymore video
All tags are in Tellimuse sildid filter. Wiki 5.1.4 In wiki and figma is "Sildid", not "Tellimuse sildid" and there should be vendors tags
If tag filter selected, Tühjenda filtrid doesn't empty tag filtering.
Figma Red icon hasn't skipped? I see red icon on every row, Even where the language direction and skill are correct

BE:

KaarelKa commented 11 months ago

@MariusJulius FE part is done. Some input for BE part:

Kuva korraga 100 doesn't work - Yeah seems BE currently has a limit of max 50
Tag filtering doesn't work - Doesn't seem to be added on BE. I added some optimistic option to FE, so these are passed to BE with the field "tag_id", which will be an array of tag ids. If the field name or structure will be somethng else, then we will also need to change on FE, so something to keep in mind.
Cost is not calculated (in sub-project view under teostajad) (BE?) - FE currently shows the "price" field that every element in the "candidates" array has, not sure if this is correct or not. They currently look like hardcoded values, but not sure, if FE is using the correct field or not.
Figma Red icon hasn't skipped? I see red icon on every row, Even where the language direction and skill are correct - Improved this a bit on FE, but currently we will always have the red icon, because an assignment doesn't have a skill assigned. FE will use the "job_definition.skill_id" field of an assignment for this check. If this is correct, then this should start working correctly, once these get attached on BE. If not, then will need some changes on FE side as well. Hopefully @thenouan can let us know.

MariusJulius commented 11 months ago

Added BE part to a separate issue (remove cost part as it seems to work): https://github.com/keeleinstituut/tv-tolkevarav/issues/566

plakitkelly commented 11 months ago

Fixed part is OK

keeleinstituut / tv-tolkevarav