search

keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Displaying errors in tag editing modal #550

Open plakitkelly opened 8 months ago

plakitkelly commented 8 months ago

1-

  1. Open tag editing modal
  2. Edit the name of one tag to the same as another tag Actual: Actual: Error is out of the modal image

2- business rule check check takes place after getting "tag already exist" error Business rules: name can't start with space or '-', name can't be longer than 50 chars, name can't be empty

  1. Open tag editing modal
  2. Delete the name of one tag / enter more than 50 chars / enter space to first char
  3. No errors about against the business rules
  4. Do steps that described in the first paragraph
  5. After getting tag already exist error, do again step 2 Actual: Error is out of the modal and business rule check doesn't happen before getting tag already exist error. Now user sees errors if something is against the business rules image

3- "Tag with such name already exist" is not translated

KaarelKa commented 7 months ago

@plakitkelly Can you retest this. Might have been fixed in the scope of another ticket + couldn't reproduce it myself right now

plakitkelly commented 7 months ago

@KaarelKa 1st part is fixed.

Is it possible to show "Kohustuslik väli" and "max 50 chars", "tühik, sidekriips pole lubatud esimese tähemärgina" errors before getting "already exist" error? User sees only disabled button but no errors. Video

The same thing is actually also in other views, only with this difference, the save button is visually disabled, although you can click and only then it shows an error, but it could show an error as soon as something is wrong. I'll do new ticket for other views later.

VaabelMaret commented 7 months ago

@MariusJulius @thenouan @kadmit

3- "Tag with such name already exist" is not translated

This error message comes from BE. Translating BE error message should be done in BE side.

NeleKo commented 7 months ago

@MariusJulius @thenouan @kadmit

3- "Tag with such name already exist" is not translated

This error message comes from BE. Translating BE error message should be done in BE side.

@VaabelMaret Estonian translation should be: "Selle nimega silt on juba olemas"

plakitkelly commented 7 months ago

2nd part is fixed

plakitkelly commented 6 months ago

https://github.com/keeleinstituut/tv-tolkevarav/issues/550#issuecomment-1842573771 translate error

KaarelKa commented 6 months ago

If 3. error is the only one that exists, then this is BE task, I think most(if not all) error messages from BE are currently in English. @MariusJulius if we don't have a task for it yet, then we should create one for translating all error messages from BE

MariusJulius commented 6 months ago

@plakitkelly closing this one as translations will be done separately here: https://github.com/keeleinstituut/tv-tolkevarav/issues/664