keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Projects and tasks with start time (BE) #563

Open MariusJulius opened 10 months ago

MariusJulius commented 10 months ago

Tasks with start time logic has been implemented but due to synchronisation issue it doesn't display start time in order creation and sub-order view.

To-do:

Update 28.11 Start time logic wasn't actually added, as the logic ticket was missing. Just the part of having it in the schema. Wiki - project creation Wiki 5.1.6 - sub-project assignment Wiki - task

To-do:

KaarelKa commented 9 months ago

@thenouan There also seems to be an issue with sending the start time to BE for some orders with a project type that should allow it.

Basically on FE we check the "value" field of the selected project type.

We get the project types from: GET https://api.dev.tolkevarav.eki.ee/translation-order/api/classifier-values?type=PROJECT_TYPE

if the value is one of:

'ORAL_TRANSLATION' 'POST_TRANSLATION' 'SYNCHRONOUS_TRANSLATION' 'SIGN_LANGUAGE'

We show the event_start_at input, however if we try to create an order with it, we get the "The event start at field is prohibited." error.

curl:

curl 'https://api.dev.tolkevarav.eki.ee/translation-order/api/projects' \ -H 'authority: api.dev.tolkevarav.eki.ee' \ -H 'accept: application/json, text/plain, */*' \ -H 'accept-language: en-US,en;q=0.9,ceb;q=0.8' \ -H 'authorization: Bearer eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJBRzRYOXR2SVhubkoxWUhiYnJHZmdYdnNYNEVVU2xGalk0RkZSekY5MjlRIn0.eyJleHAiOjE2OTk5Njk4NTQsImlhdCI6MTY5OTk2ODk1NCwiYXV0aF90aW1lIjoxNjk5OTYwOTQ5LCJqdGkiOiI4MmUwYmU5MC0yMjkxLTQ2NDItYjM3NS1jNWM0ZmFkODAyNGQiLCJpc3MiOiJodHRwczovL3Nzby5kZXYudG9sa2V2YXJhdi5la2kuZWUvcmVhbG1zL3RvbGtldmFyYXYtZGV2IiwiYXVkIjoiYWNjb3VudCIsInN1YiI6IjY5MmQwYzdlLTQzNTgtNDY5MS1hNTgyLTcwYjY3Zjk3M2JlMiIsInR5cCI6IkJlYXJlciIsImF6cCI6IndlYiIsIm5vbmNlIjoiOGQ4NzAwOTItMzM4YS00ZjBhLThmZTctYzdiNzBlMGY2MjUwIiwic2Vzc2lvbl9zdGF0ZSI6IjIwNTlkYWUxLTJkMTUtNDI5My04ZjA5LTI1OGNmM2NhNDljMSIsImFjciI6IjAiLCJhbGxvd2VkLW9yaWdpbnMiOlsiKiJdLCJyZWFsbV9hY2Nlc3MiOnsicm9sZXMiOlsib2ZmbGluZV9hY2Nlc3MiLCJkZWZhdWx0LXJvbGVzLXRvbGtldmFyYXYtZGV2IiwidW1hX2F1dGhvcml6YXRpb24iXX0sInJlc291cmNlX2FjY2VzcyI6eyJhY2NvdW50Ijp7InJvbGVzIjpbIm1hbmFnZS1hY2NvdW50IiwibWFuYWdlLWFjY291bnQtbGlua3MiLCJ2aWV3LXByb2ZpbGUiXX19LCJzY29wZSI6Im9wZW5pZCBlbWFpbCBwcm9maWxlIiwic2lkIjoiMjA1OWRhZTEtMmQxNS00MjkzLThmMDktMjU4Y2YzY2E0OWMxIiwidG9sa2V2YXJhdiI6eyJwZXJzb25hbElkZW50aWZpY2F0aW9uQ29kZSI6IjM5NjA4MTcyNzY1IiwidXNlcklkIjoiOWExZjUyYTAtNWEwOC00ZWNlLWJiMTAtMWVhNDQ1N2U1MDA3IiwiaW5zdGl0dXRpb25Vc2VySWQiOiI5YTFmNTJhMC01YjE3LTQ5N2YtOTkxOC03NTgxMjczODE4MDkiLCJmb3JlbmFtZSI6Ik1hcmt1cyIsInN1cm5hbWUiOiJQZXRlcnNvbiIsInNlbGVjdGVkSW5zdGl0dXRpb24iOnsiaWQiOiI5YTFmNTI5Yy1jYTgwLTQxZWYtOGVjOS0zM2Q1ZDM5YmJiYjEiLCJuYW1lIjoiT2ZpY2luYSBkZSBJZGlvbWFzIGRlIE1hcnF1aXoifSwicHJpdmlsZWdlcyI6WyJBRERfUk9MRSIsIlZJRVdfUk9MRSIsIkVESVRfUk9MRSIsIkRFTEVURV9ST0xFIiwiQUREX1VTRVIiLCJFRElUX1VTRVIiLCJWSUVXX1VTRVIiLCJFWFBPUlRfVVNFUiIsIkFDVElWQVRFX1VTRVIiLCJERUFDVElWQVRFX1VTRVIiLCJBUkNISVZFX1VTRVIiLCJFRElUX1VTRVJfV09SS1RJTUUiLCJFRElUX1VTRVJfVkFDQVRJT04iLCJBRERfVEFHIiwiRURJVF9UQUciLCJERUxFVEVfVEFHIiwiQUREX0RFUEFSVE1FTlQiLCJFRElUX0RFUEFSVE1FTlQiLCJERUxFVEVfREVQQVJUTUVOVCIsIlZJRVdfVkVORE9SX0RCIiwiRURJVF9WRU5ET1JfREIiLCJWSUVXX0dFTkVSQUxfUFJJQ0VMSVNUIiwiVklFV19WRU5ET1JfVEFTSyIsIkVESVRfSU5TVElUVVRJT04iLCJFRElUX0lOU1RJVFVUSU9OX1dPUktUSU1FIiwiQ1JFQVRFX1BST0pFQ1QiLCJNQU5BR0VfUFJPSkVDVCIsIlJFQ0VJVkVfQU5EX01BTkFHRV9QUk9KRUNUIiwiVklFV19QRVJTT05BTF9QUk9KRUNUIiwiVklFV19JTlNUSVRVVElPTl9QUk9KRUNUX0xJU1QiLCJWSUVXX0lOU1RJVFVUSU9OX1BST0pFQ1RfREVUQUlMIiwiQ0hBTkdFX0NMSUVOVCIsIklNUE9SVF9UTSIsIkNSRUFURV9UTSIsIkVYUE9SVF9UTSIsIkVESVRfVE1fTUVUQURBVEEiLCJFRElUX1RNIiwiREVMRVRFX1RNIiwiVklFV19UTSIsIkVESVRfSU5TVElUVVRJT05fUFJJQ0VfUkFURSIsIlZJRVdfSU5TVElUVVRJT05fUFJJQ0VfUkFURSJdfSwiZW1haWxfdmVyaWZpZWQiOmZhbHNlLCJuYW1lIjoiZWUzOTYwODE3Mjc2NS1maXJzdC1uYW1lIGVlMzk2MDgxNzI3NjUtbGFzdC1uYW1lIiwicHJlZmVycmVkX3VzZXJuYW1lIjoiZWUzOTYwODE3Mjc2NSIsImdpdmVuX25hbWUiOiJlZTM5NjA4MTcyNzY1LWZpcnN0LW5hbWUiLCJmYW1pbHlfbmFtZSI6ImVlMzk2MDgxNzI3NjUtbGFzdC1uYW1lIn0.Ww0FDRa3SFtygwaReSAw5o2TkYEdVZ7m-Kd9Bdny1T93nUhR3DlK_fnKcvpM3kvl-efvakpLVqz8zuTs7E6f8gHzX1uYkrrqU1jeTQJKw1VijguLq_0YkcGWQaFCNiSAyKBfaVREmgD9RLJffZuM0fFb_nKW343BJ2SbumsH0QM2bMlnRFxnoiD4c2TjkVpoLjE3GTTgIrfdIDtEzFxrx3fZ4p2PZbUzMTh2PpNve_pLEV5GJXIyfsbainzoz11nHUXQjkG0fg68G10pR5NbpSZQ1pvrRZjiU34Out_Ynpvket47kHem2glvdOojUCY0i6mRdoo7izBhKMMs6pg-Kw' \ -H 'cache-control: no-cache' \ -H 'content-type: multipart/form-data; boundary=----WebKitFormBoundaryxKlzDccDoyn5s5qA' \ -H 'origin: http://localhost:3000' \ -H 'pragma: no-cache' \ -H 'referer: http://localhost:3000/' \ -H 'sec-ch-ua: "Google Chrome";v="119", "Chromium";v="119", "Not?A_Brand";v="24"' \ -H 'sec-ch-ua-mobile: ?0' \ -H 'sec-ch-ua-platform: "macOS"' \ -H 'sec-fetch-dest: empty' \ -H 'sec-fetch-mode: cors' \ -H 'sec-fetch-site: cross-site' \ -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36' \ --data-raw $'------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="deadline_at"\r\n\r\n2023-11-18T10:00:00Z\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="type_classifier_value_id"\r\n\r\n97867571-db4a-42ce-a9f0-ecff435724da\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="client_institution_user_id"\r\n\r\n9a1f52a0-5b17-497f-9918-758127381809\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="manager_institution_user_id"\r\n\r\n\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="reference_number"\r\n\r\n\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="source_language_classifier_value_id"\r\n\r\nc93c5c1f-3fec-410f-ace8-137f3777aff7\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="destination_language_classifier_value_ids[]"\r\n\r\nc9839037-14b9-46e1-933a-ae28934ea6e7\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="translation_domain_classifier_value_id"\r\n\r\n9c018c24-1047-4b56-a558-cf575657a59e\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="comments"\r\n\r\n\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="accepted_at"\r\n\r\n\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="corrected_at"\r\n\r\n\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="rejected_at"\r\n\r\n\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="cancelled_at"\r\n\r\n\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="created_at"\r\n\r\n\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="feedback_files"\r\n\r\n\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA\r\nContent-Disposition: form-data; name="event_start_at"\r\n\r\n2023-11-26T10:00:00Z\r\n------WebKitFormBoundaryxKlzDccDoyn5s5qA--\r\n' \ --compressed

MariusJulius commented 9 months ago

Just in case. https://github.com/keeleinstituut/tv-tolkevarav/issues/240

plakitkelly commented 8 months ago

@MariusJulius In task tab start time is missing but in response I see event_start_at "ext_id": "LOL-2023-12-VK-153-et-EEkea-CV-1", "project_id": "9ad91653-3b6d-4258-b58e-feee877a9877", "deadline_at": "2023-12-25T01:00:00.000000Z", "event_start_at": "2023-12-17T23:00:00.000000Z",

And it's not possible to save new start time. Nothing happens..

KaarelKa commented 8 months ago

Previous response seems to be sub project response. Assignments still seem to be missing the event_start_at field

MariusJulius commented 8 months ago

Discussed this through, there was a misunderstanding.

plakitkelly commented 8 months ago

Still it's not possible to edit start time. @MariusJulius

KaarelKa commented 8 months ago

Yup FE part not done, will use the same ticked for FE

plakitkelly commented 8 months ago

Tested in 08.01 - It's Ok