search

keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Adding vendor to task table bugs (BE) #566

Open MariusJulius opened 9 months ago

MariusJulius commented 9 months ago

  1. Kuva korraga 100 doesn't work - Yeah seems BE currently has a limit of max 50 - [Will keep 50]

  2. Tag filtering doesn't work - Doesn't seem to be added on BE. I added some optimistic option to FE, so these are passed to BE with the field "tag_id", which will be an array of tag ids. If the field name or structure will be somethng else, then we will also need to change on FE, so something to keep in mind.

  3. Figma Red icon hasn't skipped? I see red icon on every row, Even where the language direction and skill are correct - Improved this a bit on FE, but currently we will always have the red icon, because an assignment doesn't have a skill assigned. FE will use the "job_definition.skill_id" field of an assignment for this check. If this is correct, then this should start working correctly, once these get attached on BE. If not, then will need some changes on FE side as well. Hopefully @thenouan can let us know. [should be fixed]

Originally posted by @KaarelKa in https://github.com/keeleinstituut/tv-tolkevarav/issues/544#issuecomment-1810096807

KaarelKa commented 8 months ago
  1. Done during another task
  2. Removed tag filtering for now
  3. Should be fixed
plakitkelly commented 8 months ago

Tested in 27.12, 1-3 are fixed - OK