search

keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Add import tmx file errors (TM view) #583

Open plakitkelly opened 9 months ago

plakitkelly commented 9 months ago

Wiki AF 3.4a 3.4a.1 The file added was not proper and system displays an error message:

  1. System checks the file format, if not compatible show message: "File format is not compatible. Please add file in .tmx format"
  2. System checks the language directions, if not compatible: "Language direction is not compatible"

Currently:

  1. Uploading other file format, user sees an error: "Tõlkemälu segmendi üleslaadimine ebaõnnestus"
  2. Uploading the TM file with other language directions, user sees: "Tõlkemälu on edukalt üles laetud", but actually is nothing uploaded (because I can't export tm). After uploading the TM file with correct language directions, I can export TM.
KaarelKa commented 9 months ago

@MariusJulius

  1. Issue is FE - We show a hardcoded error on FE regardless of what went wrong. We should either change the message or show what comes from BE (if BE can send the correct error message there)
  2. Issue is BE - Seems BE doesn't validate the language directions. For this to work correctly, BE needs to send the error and 1. needs to be done on FE, so we don't always show the same error message
MariusJulius commented 9 months ago

@PlaksoBirgit for point 2 we need to change wiki - it is not possible to detect languages from tmx easily, those can contain also multiple languages based on the examples. Rather provide some tooltip or other information for user that they are responsible for submitting correct tmx files.

PlaksoBirgit commented 9 months ago

We can go without validating languages. Users are responsible for uploading tmx files with correct languages, it will be communicated during trainings and probably will be added to the user manual

plakitkelly commented 9 months ago

Tested in 04.12 1st part is fixed. It's OK