Open MariusJulius opened 7 months ago
KaarelKa
commented
7 months ago @MariusJulius
4.1. - It's not a bug, it's currently a feature and done according to wiki. Will change it. @PlaksoBirgit should be displayed in wiki as well, if we go with this change. (https://github.com/keeleinstituut/tv-tolkevarav/wiki/A-13.-Teostaja:-T%C3%B5lkimise-vaade---CAT-tool-seadistamine-(Tellimuste-loomine,-korraldamine-ja-t%C3%B5lkimine-)#42-claim-open-task-as-vendor -- 4.1.2 section)
KaarelKa
commented
7 months ago @kadmit Currently the following requests are needed to show details for the vendor, but currently can't be done, because the user doesn't have the permission for them:
Not sure what the best solution is. For FE the easiest solution would be, if we could continue using the same endpoints, but they would just return only the necessary information, if the privileges are missing. On the other hand we are going to ingore quite a lot of privileges for this. Maybe @PlaksoBirgit can also comment about the fields that we are allowed to return to people without the corresponding privileges
KaarelKa
commented
7 months ago @MariusJulius
4.1. - Changed it for now 4.2.1 - FE issue, fixed it in this ticket, will need merge and deploy 4.2.2 - BE - Privilege issue, FE part done with other changes related to final_files 4.2.3 - BE - Privilege issue
PlaksoBirgit
commented
7 months ago @KaarelKa Related to 4.1: yes, that was initially agreed, but I guess it was not fully understood .. Rediscussed and the ideal would be if the vendor can open the job info (important to see the volume, comments and also to open files), but irrelevant things are disabled until accepting the task -> vendor can not: leave comment, upload/delete file, mark as complete, open cat tool & three dot menu
I edited the wiki: https://github.com/keeleinstituut/tv-tolkevarav/wiki/A-13.-Teostaja:-T%C3%B5lkimise-vaade---CAT-tool-seadistamine-(Tellimuste-loomine,-korraldamine-ja-t%C3%B5lkimine-)#42-claim-open-task-as-vendor p 4.2.4 and 4.2.5
PlaksoBirgit
commented
7 months ago @kadmit Currently the following requests are needed to show details for the vendor, but currently can't be done, because the user doesn't have the permission for them:
- GET /tm/api/v1/tags
- GET /tm/api/v1/tm/stats
- GET /translation-order/api/cat-tool/jobs/
- GET /translation-order/api/tm-keys/
- GET /translation-order/api/projects/
- POST /translation-order/api/media/bulk
Not sure what the best solution is. For FE the easiest solution would be, if we could continue using the same endpoints, but they would just return only the necessary information, if the privileges are missing. On the other hand we are going to ingore quite a lot of privileges for this. Maybe @PlaksoBirgit can also comment about the fields that we are allowed to return to people without the corresponding privileges
Would it be a solution to still use the privilege view_personal_task and with that privilege return info that is relevant to work with the task?
MariusJulius
commented
7 months ago Task resource - add additional checks that current user asking the task is vendor or assigned to the task or not. If is then data is enriched. For media improve privilege check (?)
KaarelKa
commented
7 months ago **Update*** Small update on the endpoints (small mistake before)
MariusJulius
commented
7 months ago First feedback: 4.2.3 CAT not available for linguist Source translatable file list only visible not able to download any files 4.3. PM doesn't see comments
KaarelKa
commented
7 months ago 4.2.3 - Removed the default checked box for assignment xliff tab Source files - Fixed FE part before last deploy, but just noticed that BE won't allow the downloading of these files for vendor. @kadmit
endpoint: GET /translation-order/api/media/download?id=1121&reference_object_id=9aad0821-99c0-4904-968b-e16ef4a564c2&reference_object_type=subproject&collection=source
Basically I guess we should allow assignee or candidate to download it without Privilege checks
4.3 - FE issue - fixed under this task
KaarelKa
commented
7 months ago FE part in CR
MariusJulius
commented
7 months ago Relates to: #635
plakitkelly
commented
7 months ago Currently vendor can't accept the job. Will test again when it's fixed
plakitkelly
commented
7 months ago 4.2.2 After selecting a file to upload to 'Minu valmisfailid', nothing happens, file upload does not start. (Kaarel is finalising) It uploads, but user doesn't see in UI without refresh. (#676 )
Another issues are fixed. I move this ticket to done.
plakitkelly
commented
7 months ago All fixed
Client: Esimene Tellija 33708200201 Project manager: Esimene Korraldaja 46812264771 Vendor: Esimene Teostaja 47904109501 Order ID: PPA-2023-12-T-22
4.1. Potential sub-order info not visible to vendor before accept. (privilege issue? for pm and client fields are visible) The vendor cannot see files or the volume of the job before accepting the job offer. This is vital information they need before accepting/claiming the job.
4.2. After linguist vendor has accepted the job they can see the volume and source file. But after accepting/claiming the task they can only see upload/download a file + mark job as ready button, but they cannot start working on it in the CAT tool. Opening the XLIFF file in CAT tool is not visible for them. But the workflow is 'Tõlkimine (CAT)' inside with the CAT, they need to work with the CAT tool in order to translate the source file. To summarise: 4.2.1 The download source file function is not working, button deactivated; (needs review) 4.2.2 After selecting a file to upload to 'Minu valmisfailid', nothing happens, file upload does not start. (Kaarel is finalising) 4.2.3 Vendor cannot work in the CAT tool to translate the segments.(section missing) 4.3. When adding/typing notes to the PM in 'Minu märkused', and marking job ready 'Märgi lõpetatuks', I see these notes are not saved. Vendor should be able to leave and save notes to the Project Manager before finishing their task. Checked with the PM user as well, they do not see any notes left by the teostaja in 'Teostaja märkused' UI section. (notes being finalised by Markus)