keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Adding additional skills (FE) #632

Open MariusJulius opened 7 months ago

MariusJulius commented 7 months ago

Steps:

  1. Open vendor detail view
  2. Scroll down to "Hinnakiri" section
  3. Go to another page (not 1st)
  4. Click on edit button in any language direction row
  5. Go to "Lisa oskused" tab and select any skill that is not selected
  6. Set prices and click "Salvesta"

Actual: User doesn't see added skill in selected page. If user goes to 1st page, there is added skill in first row. Now I have this language direction on 1st and another page. If user wants to add more skills on first (or another) page, user cannot see that some skills are selected (this one what is on another page) If user adds selected skill again, then "Salvesta" button does nothing.

Expected: Group same language direction skills and show selected skills in "Lisa oskused" tab

VIDEO

Cannot reproduce anymore, because step 6 doesn't work. Salvesta button does nothing. (30.11)

Originally posted by @plakitkelly in https://github.com/keeleinstituut/tv-tolkevarav/issues/469#issuecomment-1766101802

KaarelKa commented 7 months ago

To avoid the issue with some skills for a certain language direction not being in the correct order, we will also need some changes from BE side. Adding lang_pair filter from BE and applying it on FE should work.

@kadmit Maybe you can take a look and let me know how much time this would take

plakitkelly commented 7 months ago

Tested in 13.12 - It's OK