search

keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Vendor selection - api /institution-users filtering by statuses (BE) #633

Open MariusJulius opened 7 months ago

MariusJulius commented 7 months ago

Currently waiting for BE to be done with api /institution-users filtering by statuses

Originally posted by @IngaSokman in https://github.com/keeleinstituut/tv-tolkevarav/issues/505#issuecomment-1778582462

Blocks: https://github.com/keeleinstituut/tv-tolkevarav/issues/505 Wiki Users with status "deactivated" or "archived" should not be displayed in the list (modal where vendor is selected)

To-do:

kadmit commented 7 months ago

@IngaSokman Here is the PR with the fix: https://github.com/keeleinstituut/tv-authorization/pull/82

Note: The endpoint will not return deactivated and archived users anymore, there is no need to pass the status filter.

MariusJulius commented 7 months ago

@KaarelKa does something needs to be done by FE as well as it is still not working?

KaarelKa commented 7 months ago

@MariusJulius No, but it's most likely related to the syncing issue. @thenouan Did you have time to look into it ?

plakitkelly commented 4 months ago

image image I tried another institution, users were created in 29.01, main user (Emelie Hauck) was deactivated in 10.12. Syncing issues or it syncs with delay. I'll check again later, but in my main institution are still deactivated and archived users in add/remove vendor modal.

plakitkelly commented 1 month ago

Update: Checked again. There is no delay for syncing. I still see activated and archived users in ad/remove vendors modal. (look screenshot in my previous comment)