keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Adding institution logos (FE) #637

Open MariusJulius opened 7 months ago

MariusJulius commented 7 months ago

Adding logo URL-s for institutions

Backend has a solution for logos, FE uses currently static image. Later on in a separate task BE will make a development for storing it as a file: https://github.com/keeleinstituut/tv-tolkevarav/issues/735

To:do:

Logos (just in case) Politsei- ja Piirivalveamet: https://broneering.politsei.ee/Assets/Client/Header/logo.png Haridus- ja Teadusministeerium: https://www.hm.ee/sites/default/files/HTM_EST.svg Rahandusministeerium: https://www.fin.ee/sites/default/files/Rahandusministeerium_EST.svg Justiitsministeerium: https://www.just.ee/sites/default/files/JUSTIITSMINISTEERIUM_EST.svg Eesti keele instituut: https://portaal.eki.ee/templates/eki/images/mustkoma.png Prokuratuur: https://www.prokuratuur.ee/sites/default/files/1cm_est.png

KaarelKa commented 4 months ago

@thenouan Any ideas on this one ?

KaarelKa commented 2 months ago

@thenouan @MariusJulius Did the FE change, but it seems that at least in dev the logo_url is missing from institutions. At least the one I'm testing with just has logo_url: "https://logo.com"

Would be good to populate them with the values given here before deploy, so this task doesn't bounce back from testing. Probably even more important to make sure they are populated in live