search

keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

It shows last change date for vendor price list even if there is no price list (FE) #649

Open MariusJulius opened 9 months ago

MariusJulius commented 9 months ago

It shows last change date for vendor price list even if there is no price list image

Originally posted by @estakaad in https://github.com/keeleinstituut/tv-tolkevarav/discussions/498#discussioncomment-7311716

BE ticket: #656

KaarelKa commented 9 months ago

@MariusJulius Needs both BE and FE changes. We currently don't get the updated_at and created_at values from BE, so they are just taken from the first price element we get when fetching the list and seems to fall back on current date. This means that currently we are not showing the correct date there. Mentioned to @thenouan as well, but would be good to have tasks for this.

Endpoint: GET translation-order/api/prices?vendor_id=

created_at - Timestamp when the first price object was added to this vendor updated_at - Timestamp of last edit to any price object that belongs to this vendor

plakitkelly commented 7 months ago

It's unclear for me what timestamp it should show on "Hinnakirja andmeid muudetud". It makes sense to me to show the timestamp when the price list has been changed (added, edited, removed) but currently it shows the moment when I added new user to vendor's database image I don't have any price list added image

plakitkelly commented 7 months ago

Sorry, I just read that. Ignore my previous comment created_at - Timestamp when the first price object was added to this vendor updated_at - Timestamp of last edit to any price object that belongs to this vendor

And I found out that I got it wrong. Firstly it saves the timestamps when a new vendor is added. It will be saved to both, created_at and updated_at (adding users works the same way).

But before I was confused about this comment This tester got it the same way I did.

I think there should be "Teostaja loodud"

Now I found in figma that there should be "Teostaja loodud" AND "Hinnakiri loodud" pricelist not added pricelist added

MariusJulius commented 7 months ago

Need to confirm with @kadmit should both price list and vendor changes be covered in: https://github.com/keeleinstituut/tv-tolkevarav/issues/656

plakitkelly commented 7 months ago

https://www.figma.com/file/VqCwED3Dymn7L1gGoAOK27/EKI-t%C3%B5lkev%C3%A4rav?type=design&node-id=835-81184&mode=design&t=eIhA4AwwvFJEMkVM-4

There should be "Teostaja loodud" as well. I see both timestamps, vendor and pricelist image

plakitkelly commented 5 months ago

Tested in 15.04 - It's OK