Supporting 3 decimal places (BE and FE)

keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)

1 stars 0 forks source link

Supporting 3 decimal places (BE and FE) #661

Open MariusJulius opened 6 months ago

MariusJulius commented 6 months ago

Enduser request:

When setting the price lists, I needed to set the price of the word to 0.088, but now it does not allow three decimal places. I suggest you could. Otherwise, I can't convert the current prices. In the future, it is intended that only two decimal places remain.

To-do:

allow adding 3 decimal places when adding price list (needs both BE and FE change)

KaarelKa commented 6 months ago

Will do FE, once BE is done, otherwise we will disable setting of prices

kadmit commented 6 months ago

@KaarelKa BE part is under review:

https://github.com/keeleinstituut/tv-translation-order/pull/114

KaarelKa commented 6 months ago

FE accepts any number of decimal points right now. Will leave this validation for BE for now. Longer term plan is to add masking, but skipping it for now.

However currently the errors for wrong price entry were not displayed, so fixed that part.

plakitkelly commented 6 months ago

Tested in 27.12 - It's OK