Missing language error (BE)

keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)

1 stars 0 forks source link

Missing language error (BE) #672

Open MariusJulius opened 6 months ago

MariusJulius commented 6 months ago

getting some “Missing language” error, when trying to set tup cat-tool (POST api/cat-tool/setup), picked 2 files and 2 translation memories, curl in thread.

curl.txt

kadmit commented 6 months ago

The response that we got means that the language wasn't passed into MateCat, locally it works correctly, so it seems that we need to debug it inside the cluster.

thenouan commented 5 months ago

Issue is with filesizes. With that specific subproject mentioned in the attached curl following log lines are outputted by cat service

[12-Feb-2024 10:59:05 UTC] PHP Warning:  POST Content-Length of 97318635 bytes exceeds the limit of 8388608 bytes in Unknown on line 0
[12-Feb-2024 12:59:05 Europe/Tallinn] PHP Notice:  Undefined index: private_tm_key in /var/www/html/lib/Controller/API/NewController.php on line 204
[12-Feb-2024 12:59:05 Europe/Tallinn] PHP Notice:  Undefined index: source_lang in /var/www/html/lib/Controller/API/NewController.php on line 788
[12-Feb-2024 12:59:05 Europe/Tallinn] PHP Notice:  Undefined index: target_lang in /var/www/html/lib/Controller/API/NewController.php on line 797

MariusJulius commented 5 months ago

Issues was initially reported by @KaarelKa . I suppose we would need better error message then if it is about the filesize not about missing language @KaarelKa @thenouan ?

thenouan commented 5 months ago

It is Matecat's issue, not a FE error handling issue. Flow is the following:

FE makes request to translation-order-service
- translation-order accepts it successfully, since no files are passed with /cat-tool/setup endpoint, but only file ID's that are saved previously during project creation
Translation-order-service sends these files to Matecat with CAT project creation endpoint (api/v1/new)
- translation-order-service gathers previously saved files and attaches these to Matecat's /api/v1/new request
- Matecat refuses this request, because of the file sizes limit opposed on matecat's side
- Matecat returns invalid error message about (Missing language) because due to file size limit this request body is truncated and rest of the parameters (source_lang and target_lang) are not visible to Matecat's validation logic and returns "Missing language." because of that

Since it is a Matecat issue then maybe @kadmit could have a look at it

MariusJulius commented 2 months ago

@KaarelKa can you test this as it is not clear what are the steps to reproduce?

KaarelKa commented 2 months ago

@MariusJulius @kadmit Did a test with a couple of bigger files in dev. Got a new error now: 422 "message": "Project Conversion Failure"

Not sure if related or not

curl:

curl.txt

MariusJulius commented 2 months ago

Conversion error is something else, also mentioned here: https://github.com/keeleinstituut/tv-tolkevarav/issues/546 Closing this one.