keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Adding volume manually - minimal option (FE /BE) #684

Open plakitkelly opened 9 months ago

plakitkelly commented 9 months ago

Click on Lisa maht in task tab Choose Lisa maht käsitsi Select Minimaalne (should be "Miinimum tasu") Can't save 0 or other values.

User sees Viga.

image

MariusJulius commented 9 months ago

@PlaksoBirgit is the logic like that: User adds minimum cost (can't edit any field) and when vendor is added it will display the price according to vendor price?

PlaksoBirgit commented 9 months ago

@MariusJulius it should be as with other options - initially when no vendor has accepted and "Miinimum tasu" is selected, system displays 0, but PM can add values (to estimate approximate cost of the sub-project) and save them. After a vendor accepts the task then it should be retrieved from their pricelist and the initially added values will be over written, but if needed it can still be edited by PM. (in CAT tool volume modal editing of the minimum value is not possible)

MariusJulius commented 9 months ago

@KaarelKa as I remember BE doesn't accept minimum price at the moment, so fixed needed on BE side?

KaarelKa commented 9 months ago

@MariusJulius Yeah, I will disable this field in FE

KaarelKa commented 9 months ago

@MariusJulius @plakitkelly Okay this was actually already removed before the last deploy. So there is nothing more we can do on FE right now. We can add it back, once BE allows the saving of minimum value.

MariusJulius commented 8 months ago

@PlaksoBirgit is this minimum fee as a separate unit needed at all? In case price is lower than minimum fee, it uses the vendor minimum price. No point to set this manually as it is only relevant to vendor - not to get below the fee. Maybe add extra information about minimal fee - which will be not editable (or only if minimal fee is higher than end price).

PlaksoBirgit commented 8 months ago

@MariusJulius has there been extra logic added that we can't add below minimum price (vendor always has to get at least the miminum fee)? the initial idea was that PM can use it if the work load is small (they can also then easily see what is the minimum for this specific vendor)

MariusJulius commented 8 months ago

@PlaksoBirgit so to confirm as this behaves a bit different then other pricing options with price x unit. Hinna väärtus (EUR) / unit price is the field where minimum fee is entered. Quantity field is locked for editing and total shows the same as unit price (the min fee).

PlaksoBirgit commented 8 months ago

@MariusJulius yes, Hinna väärtus is the place where you can enter the minimum fee and we can disable the quantity fee or if it is easier to make for FE then just add quantity "1" and leave it editable

MariusJulius commented 8 months ago

@kadmit please check if comments are ok and we can proceed?

MariusJulius commented 4 months ago

@NeleKo here we need one more discussion on final solution.

MariusJulius commented 4 months ago

@NeleKo please just in case confirm the description below so it would be correctly implemented.

Min price is not included in the calculations as other prices (eg summing up pages, words etc) - it will be done in the later phases. Min fee also doesn't replace any other price if there is no value.

If there is only one unit (minimal fee) added then cost is calculated based on minimal fee. E.g PM has set minimal fee 20 and quantity 2 and if Vendor has minimal fee value X in price list then this is multiplied 2X and shown in the cost par next to vendor. Vendor minimal fee doesn't overwrite the PM added minimal fee in the volume modal.

MariusJulius commented 3 months ago

I suppose we need to enable it on FE side also.