search

keeleinstituut / tv-tolkevarav

Tõlkevärav (Translation Hub)
1 stars 0 forks source link

Adding special instructions for splitted tasks (FE) #705

Open MariusJulius opened 5 months ago

MariusJulius commented 5 months ago

If the task is shared (e.g. between vendor 1 and vendor 2), the special instructions added to the task 'Vendor 2' are not saved and are not displayed to the vendor. This is a bug, special instructions for all tasks must be saved and displayed at all times. Tested this: Suborder ID PPA-2024-01-T-141-ru-RUet-EE-1/1.1 (special instructions only) PPA-2024-01-T-141-ru-RUet-EE-1/1.2 (none, although we added them at the beginning) Additionally, the times are not displayed correctly under the task for the doer.

plakitkelly commented 5 months ago

I see that special instructions and times are displayed correctly image image

NeleKo commented 5 months ago

Can the linguist who accepts these tasks also see the 'erijuhis' correctly?

plakitkelly commented 5 months ago

Before accepting image

After accepting image

MariusJulius commented 5 months ago

So couldn't reproduce.

plakitkelly commented 5 months ago

Found the problem:

  1. Create new order
  2. Open suborder task tab
  3. Split task
  4. Enter vendor1
  5. Enter vendor2 6. Enter deadline date (2) 7. Enter special instructions (2) 8. Enter deadline time (2) 9. Getting error: the deadline at field is required
  6. Send sub-order to vendors

VIDEO

And in vendor view: image

Actual: Vendor is not saved when entering date firstly, then special instructions and then the time

plakitkelly commented 5 months ago

About this: Additionally, the times are not displayed correctly under the task for the doer. I couldn't find any issues with the times. All known issues are in #704

plakitkelly commented 5 months ago

I think that this problem will be solved with this https://github.com/keeleinstituut/tv-tolkevarav/issues/704#issuecomment-1909744177 Then both fields are already pre-filled and the user will not get this error.

image @PlaksoBirgit What date should be shown when splitting the task? The same date as the suborder's deadline or the same date as vendor1 or anything else?

PlaksoBirgit commented 5 months ago

@plakitkelly The same date as the suborder's deadline

MariusJulius commented 4 months ago

There was an issue with splitting, solved in BE ticket #713 which is in review, probably now it can be fixed.

plakitkelly commented 4 months ago

Today it's not fixed

MariusJulius commented 3 months ago

Should be rechecked when related tasks are done.

MariusJulius commented 2 months ago

Seems to be working now.