Open plakitkelly opened 4 months ago
@PlaksoBirgit please validate the ticket
This part:
Project type: "Toimetatud tõlge" -> "Toimetatud tõlge (CAT)" "Toimetatud tõlge, Ülevaatus" -> "Toimetatud tõlge (CAT), Ülevaatus"
Remove: Skill: "Infovahetus"
OK!
Task names should all be reviewed - it is more global issue. If I check WF where tasks are Käsikirjaline tõlkimine, ülevaatus, the Käsikirjaline tõlkimine tab is named "Tõlkimine".. Suuline tõlge WF -> the tab is named "Tõlkimine" So it seems that all the different WF translation tasks have a common name in the tabs- "Tõlkimine" but by design we should show for which exact tasks we are filling data for..
Also what I noticed - I selected "Toimetatud tõlge" WF and there are two mistakes seen ->
First part is BE and solved in #720 1) Updated project type classifiers Toimetatud tõlge" -> "Toimetatud tõlge (CAT)" "Toimetatud tõlge, Ülevaatus" -> "Toimetatud tõlge (CAT), Ülevaatus"
2) Remove (fixed) Skill: Infovahetus - Information exchange
Updated project type classifiers Toimetatud tõlge" -> "Toimetatud tõlge (CAT)" - OK "Toimetatud tõlge, Ülevaatus" -> "Toimetatud tõlge (CAT), Ülevaatus" - OK
Remove (fixed) Skill: Infovahetus - Information exchange - OK
@thenouan @kadmit
Hey, maybe you can check the copies/translations of job_short_name in job_definition. It seems that some of them have the (CAT) part included and some don't (The ones that actually use CAT).
For example:
id: "9aa7dc6b-a915-44c6-9371-6d06240ef6c9" job_key: "job_translation" job_name: "Tõlkimine sisemises CAT tööriistas koos toimetamisega" job_short_name: "Toimetatud tõlge"
id: "9a722357-661c-46dd-9baa-fd78fbf7d5d1" job_key: "job_translation" job_name: "Tõlkimine sisemise CAT tööriistaga" job_short_name: "Tõlkimine(CAT)"
Issue is that on FE we need to show the (CAT) part. Previously this was added on FE part, which means that currently the 2. example would have it doubled "Tõlkimine(CAT) (CAT)". I would propose that we add them only on BE side and I'll remove the FE part.
Will already do the removing during this task
Tested in 14.06 Toimetatud tõlge" -> "Toimetatud tõlge (CAT)" - NOT OK "Toimetatud tõlge, Ülevaatus" -> "Toimetatud tõlge (CAT), Ülevaatus" - NOT OK
Actual: "Toimetatud tõlge"
@KaarelKa @kadmit not sure if this needs fix in FE or BE.
@kadmit Were the texts updated on BE already or not yet ? (Check my previous comment here)
@KaarelKa texts will be updated after the next deploy
Tested in 05.07 - it's ok
Change:
Task names should all be reviewed - it is more global issue. If I check WF where tasks are Käsikirjaline tõlkimine, ülevaatus, the Käsikirjaline tõlkimine tab is named "Tõlkimine".. Suuline tõlge WF -> the tab is named "Tõlkimine" So it seems that all the different WF translation tasks have a common name in the tabs- "Tõlkimine" but by design we should show for which exact tasks we are filling data for..
Also what I noticed - I selected "Toimetatud tõlge" WF and there are two mistakes seen -> ![Uploading image.png…]()
tab name is wrong also the indication Teostaja 1(tõlkimine) is wrong -> this too should indicate exact task what the vendor is/was doing -> Teostaja 1 (Toimetatud tõlge)