Notification spam

[plakitkelly]

Who - Teostaja, tõlkekorraldaja, tõlkekorraldaja II (privileges are the same as in _privileegide.tabel-301123-071240.pdf table) Where - Teostajate andmebaas

[MariusJulius]

should be solved but not deployed.

[plakitkelly]

Not fixed in 14.06

[MariusJulius]

@plakitkelly same roles, same view etc?

[plakitkelly]

Yes

[KaarelKa]

@plakitkelly How many errors did you get ? Was it 4 again or 2 ?

Can you also check network tab and see if you get 1 error per unique request that failed or more. Currently I know of 2 requests that will fail on that page and for each of those we show an error, but I couldn't reproduce a case, where we show more than 1 error per request made.

[KaarelKa]

@MariusJulius 1 thing we could improve here and in some other places, is to skip the request made to BE, if we already know of FE that the user doesn't have the privilege to do that request. This would also involve disabling some extra buttons in those cases. For example the role filters button in this view, if user doesn't have the privilege to fetch roles.

We already have this logic in some places, but in others we didn't have a concrete understanding of whether a user without a certain privilege should be able to access that resource (For example fetching roles without the correct privilege for use in filters). During the last longer grooming we decided to make sure that privileges are logical and you need to have the corresponding privilege, which means that there are places in FE which can be improved based on this information.

Hopefully we can stick it to maintenance, as this is more of a nice-to-have visual update

[plakitkelly]

@KaarelKa 2 errors. roles and privileges. 1 error per request

[KaarelKa]

Then all good, this is the intended behaviour