keeleysam / instadmg

Automatically exported from code.google.com/p/instadmg
0 stars 0 forks source link

findInstallerDisc doesn't seem to find the newest installer disc #59

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Put 10.6.0 retail and 10.6.3 retail in the InstallerDiscs folder.
2. Run instaup2date with vanilla.catalog

What is the expected output? What do you see instead?

InstaDMG runs with the 10.6.0 disc selected.

What version of InstaDMG are you running? What revision number (this should
be the second line of your package log)?

svn rev 364

What OS are you running on (booted from)?

10.6.4 Server

What OS are you installing?

10.6.4

Please provide any additional information below.

Not sure if it's the catalog or the code, how do I find the build numbers of my 
DMGs?

Original issue reported on code.google.com by MagerV...@gmail.com on 23 Sep 2010 at 8:50

GoogleCodeExporter commented 9 years ago
The system version is on the Installer disc, at:

/System/Library/CoreServices/SystemVersion.plist

You can get the specific information with this command:

defaults read /path/to/mount/System/Library/CoreServices/SystemVersion 
ProductBuildVersion

And besides that information what I need is exactly where the disc came from. I 
just want to make sure that we are interpreting the word "retail" the same.

Oh... and I generally don't recommend running InstaDMG on your server (making a 
guess). Not because it does not work fine for that, but because badly written 
installers can leak out and write things to your server. And presumably you 
have services that you don't want going down on that server.

Original comment by kuehn.k...@gmail.com on 23 Sep 2010 at 9:45

GoogleCodeExporter commented 9 years ago
Retail as in box bought over the counter with 10.6.3 sticker on.

My 10.6.0 disc is build 10A432
My 10.6.3 disc is build 10D575

Good point about running it on the server (but so far it has been working 
nicely). Maybe add a warning if it's run on a server OS?

Original comment by MagerV...@gmail.com on 23 Sep 2010 at 10:40

GoogleCodeExporter commented 9 years ago
Both of these are already in the repository as of rev370.

Original comment by kuehn.k...@gmail.com on 24 Sep 2010 at 1:31

GoogleCodeExporter commented 9 years ago
My bad - I was running svn 371 (but instadmg.bash prints out 364 when it runs). 
I took a quick look at the code, and on line 180 the candidate version is 
compared with the image candidate itself, rather than if it's smaller than 
macOSInformation['macOSBuild']:

180 |    elif bestCandidateVersion > baseImageCandidate:

PS: candidateConainter and supress are misspelled :)

Original comment by MagerV...@gmail.com on 24 Sep 2010 at 7:29