search

keeleysam / munki-exported

Automatically exported from code.google.com/p/munki
Other
0 stars 0 forks source link

Forced logout prompt issues #195

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If a package is set to be a forced install, and munki starts its countdown 
prompts, the user can click okay to defer the install.  If the user then lets 
the install run without logging out, the countdown prompts will return.  If the 
user runs the Managed Software Update application, it will tell them that their 
software is up to date.

In addition, the GUI seems to put the dialog box off to the left instead of on 
top of the munki window.

munkitools 0.8.3.1634.0 on 10.7.4 and 10.8.1

Screenshot of GUI attached.

Original issue reported on code.google.com by sam.kee...@gmail.com on 7 Sep 2012 at 4:41

Attachments:

GoogleCodeExporter commented 9 years ago 
Trying to clarify the issue:

Are you saying that if the install is taking place and takes a while, it's 
possible for the alerts to attempt to appear over the status window as shown in 
your screen shot?  The alert sheet is attached to MSU.app's "main" window, not 
the status window. But the main window is not visible in the case, so it 
appears the alert sheet is attached to where the window last appeared.

You don't mean that the alerts appear _after_ the install is complete, do you?

-Greg

Original comment by gregnea...@mac.com on 7 Sep 2012 at 4:52

GoogleCodeExporter commented 9 years ago 
Yes, I mean that the alerts appear after the install is complete.  In this 
instance, at the 60 minute warning, I clicked OK, then clicked install without 
logout.  The warning came up again at 45 minutes and at 30 minutes, and 
continued on and forced the logout, where it proceeded to install nothing.

Original comment by sam.kee...@gmail.com on 7 Sep 2012 at 4:55

GoogleCodeExporter commented 9 years ago 
Also, clicking OK at these warnings will present the "all software is up to 
date" message.

Original comment by sam.kee...@gmail.com on 7 Sep 2012 at 4:57

GoogleCodeExporter commented 9 years ago 
"Yes, I mean that the alerts appear after the install is complete.  In this 
instance, at the 60 minute warning, I clicked OK, then clicked install without 
logout.  The warning came up again at 45 minutes and at 30 minutes, and 
continued on and forced the logout, where it proceeded to install nothing."

In these cases, does the status window display, or the Managed Software Update 
"main" window display?

Original comment by gregnea...@mac.com on 7 Sep 2012 at 4:59

GoogleCodeExporter commented 9 years ago 
At those times it is always the status window, the MSU main window does not 
open unless OK is clicked.

Original comment by sam.kee...@gmail.com on 7 Sep 2012 at 5:01

GoogleCodeExporter commented 9 years ago 
The log, every item is listed as already installed, though I scrubbed the list 
to the two items that were installed.  The forced install was the Java 2012-005 
update.

Original comment by sam.kee...@gmail.com on 7 Sep 2012 at 5:14

Attachments:

GoogleCodeExporter commented 9 years ago 
I'm having a hard time understanding how this could happen.

/usr/local/munki/logouthelper is the process that posts the logout warnings.

When logouthelper runs, it checks /Library/Managed Installs/InstallInfo.plist 
for items with upcoming forced logouts.

But once an install begins, that file is removed. (See 
http://code.google.com/p/munki/source/browse/code/client/munkilib/installer.py#1
142)

So logouthelper should just exit when /Library/Managed 
Installs/InstallInfo.plist doesn't exist.

Original comment by gregnea...@mac.com on 7 Sep 2012 at 5:44

GoogleCodeExporter commented 9 years ago

Original comment by gregnea...@mac.com on 7 Sep 2012 at 5:45

GoogleCodeExporter commented 9 years ago 
I just ran into this again, with Flash Player set to a forced install time that 
had already passed by 12+ hours.  The prompt came up warning that a logout 
would occur in 60 minutes, so I quit Safari (a blocking application) and 
allowed it to install.

Fifteen minutes later, MSU.app popped back up warning that a logout would be 
forced in 45 minutes, with an empty list of software to install.  The window 
can be dragged around independently of the warning, but closing the MSU.app 
main window gets rid of the warning too.

Original comment by sam.kee...@gmail.com on 2 Mar 2013 at 6:02

Attachments:

GoogleCodeExporter commented 9 years ago 
Also, when this happens, InstallInfo.plist does not contain anything in any 
array other than processed_installs and processed_uninstalls.

Original comment by sam.kee...@gmail.com on 2 Mar 2013 at 6:06

GoogleCodeExporter commented 9 years ago 
Any chance you grabbed a copy of InstallInfo.plist when this is happening? And 
how about the log?

Original comment by greg.nea...@disneyanimation.com on 2 Mar 2013 at 6:48

GoogleCodeExporter commented 9 years ago 
I think I'm beginning to understand this issue. I couldn't see how it could 
happen, but that was based on the code I had written in June 2011, and I had 
not really looked at the changes since then.

In May 2012, 4cddf73b2c5e0c3a24ddc68b9fb2687350ce46fb was a change that 
attempts to reset the minimum notification time to 60 minutes to prevent a 
situation where a machine is awakened or powered up with less than 60 minutes 
until a forced logout.

But I'm seeing a logic error that might cause the behavior you've seen.

I've attached a possible fix -- it's a replacement version of 
/usr/local/munki/logouthelper

If you can reproduce this issue, could you test this change?

Original comment by gregnea...@mac.com on 2 Mar 2013 at 7:36

Attachments:

GoogleCodeExporter commented 9 years ago 
I will try reproducing it next week and testing the fix.  I think it can be 
done by letting a forced item be installed after the 60 minute warning.

Original comment by sam.kee...@gmail.com on 3 Mar 2013 at 12:23

GoogleCodeExporter commented 9 years ago 
Sam reports the issue is fixed with this change: 
http://code.google.com/p/munki/source/detail?r=f8f558edc57b07bc19aba4efb8b243b0b
320900c

Original comment by gregnea...@mac.com on 8 Mar 2013 at 9:59

GoogleCodeExporter commented 9 years ago 
Thanks Greg!

Original comment by sam.kee...@gmail.com on 8 Mar 2013 at 10:44