search

keeleysam / munki-exported

Automatically exported from code.google.com/p/munki
Other
0 stars 0 forks source link

Munki 2.0.0.2068 - MSC app icons do not update until closed/re-opened #330

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Run MSC and cache icons
2. View application
3. Update icon on server
4. Run "check again" on MSC Update tab
5. Go back to application

6. Close out of MSC and re-open to see new icon.

What is the expected output? What do you see instead?

Icon should update. While the actual cache updates in /Library/Managed 
Installs/icons, MSC does not reflect this change until it is closed and 
re-opened.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by eriknico...@gmail.com on 17 Jun 2014 at 9:03

GoogleCodeExporter commented 9 years ago 
I accidentally stumbled on this one when I imported an icon with the wrong 
dimensions. After fixing it, I noticed the icon was still stretched. I tried 
yet again and I still had the same stretched icon.

Original comment by eriknico...@gmail.com on 17 Jun 2014 at 9:05

GoogleCodeExporter commented 9 years ago 
What happens if you hit Command-R or choose the refresh menu item?

Original comment by gregnea...@mac.com on 17 Jun 2014 at 9:37

GoogleCodeExporter commented 9 years ago 
The icon is fixed with both options.

Original comment by eriknico...@gmail.com on 17 Jun 2014 at 10:33

GoogleCodeExporter commented 9 years ago 
I may choose to defer any potential action on this. Currently, to avoid 
unsightly browser-style refresh "flash" after an updatecheck or install run is 
completed, we do an AJAX-style update where the DOM is modified with the new 
information. Apparently that does not cause the WebView to pick up new icons as 
well, since only the HTML is changing.

Rather than degrade the user experience for the common case (no "live" changes 
to product icons), right now we'll live with less-than-ideal behavior for the 
uncommon case.

A possible fix would be to do the AJAX-style update unless we detect the icons 
directory has been modified; then we can trigger a full refresh of the WebView.

There is a similar issue if the other client customization resources 
(showcase/banner, sidebar, footer) are modified.

Original comment by gregnea...@mac.com on 18 Jun 2014 at 9:49

GoogleCodeExporter commented 9 years ago 
That's fine. This is definitely an uncommon case and should only impact admins 
who are "live" upgrading to Munki 2 (and even then only Munki 2 clients).

Original comment by eriknico...@gmail.com on 19 Jun 2014 at 12:06