search

keeleysam / munki-exported

Automatically exported from code.google.com/p/munki
Other
0 stars 0 forks source link

Pull request verbosity #336

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Could you review 
https://code.google.com/r/arjenvanbochoven-munki/source/detail?r=62986bac548f77b
9c349a392f558ecddcb569e89&name=environment-verbosity

I would like to signal the verbosity level to pre- and postflight scripts

Original issue reported on code.google.com by Arjen.va...@gmail.com on 23 Jun 2014 at 9:39

GoogleCodeExporter commented 9 years ago 
Could you bring this up for discussion on munki-dev? At the very least, I think 
we'd want to pseudo-namespace the variable name.

I'm not a huge fan of environment variables in general; they are an approach 
that leads to hard-to-debug unexpected interactions. But maybe I'm a minority.

Original comment by greg.nea...@disneyanimation.com on 23 Jun 2014 at 9:44

GoogleCodeExporter commented 9 years ago 
I sent in a new commit: 
https://code.google.com/r/arjenvanbochoven-munki/source/detail?r=2af6c13f87a7b08
022b059e840fcbc196fbc6532&name=environment-verbosity

Original comment by Arjen.va...@gmail.com on 24 Jun 2014 at 10:28

GoogleCodeExporter commented 9 years ago 
merged to both master and Munki2

Original comment by gregnea...@mac.com on 24 Jun 2014 at 10:41