keeleysam / munki-exported

Automatically exported from code.google.com/p/munki
Other
0 stars 0 forks source link

Download lang specific ASUS descriptions [Munki2 enhancement request] #369

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Now that looks like Munki2 will be available in many different languages, it 
would be interesting if it could download the language specific descriptions 
for the Apple updates.

Original issue reported on code.google.com by nbalonso on 21 Aug 2014 at 5:40

GoogleCodeExporter commented 9 years ago
Current behavior attached

Original comment by nbalonso on 21 Aug 2014 at 5:46

Attachments:

GoogleCodeExporter commented 9 years ago
This is a great suggestion. I wonder why no-one brought this up years ago? I 
can't promise it will make it into the first "official" release of Munki 2; I 
really want to do an official release very soon and so need to limit the amount 
of new code being added.

Original comment by gregnea...@mac.com on 21 Aug 2014 at 2:02

GoogleCodeExporter commented 9 years ago
Most of the needed code is already present:

https://code.google.com/p/munki/source/browse/code/client/munkilib/appleupdates.
py#385

It was borrowed from reposado. Since managedsoftwareupdate is running as root, 
I suspect it's picking up _root_'s language preferences (which are almost 
certainly Apple's defaults, namely US English)

Original comment by gregnea...@mac.com on 21 Aug 2014 at 2:09

GoogleCodeExporter commented 9 years ago
One approach could be to download all the languages and store them in the local 
plist. Then as the app executes in the user context we can know the language 
and display only the appropriate one.

This should also cover the odd cases where two users of the same machine have 
the UI in different languages.

The downside would be a little more text to download and store, but I think 
this is minimal.

Original comment by nbalonso on 23 Aug 2014 at 4:26