search

keeleysam / tenfourfox

Automatically exported from code.google.com/p/tenfourfox
0 stars 0 forks source link

checkStackPointer should be completely optimized away in opt builds #160

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In MacroAssemblerPPC, we should just completely obliterate the 
checkStackPointer functions in opt builds because they are pure asserts. We 
could do this for 10.x also since it's a safe change.

Original issue reported on code.google.com by classi...@floodgap.com on 31 May 2012 at 2:42

GoogleCodeExporter commented 9 years ago 
We should have a #ifndef DEBUG where they are turned into "nothing" and 
checkStackPointer isn't even compiled.

Original comment by classi...@floodgap.com on 31 May 2012 at 2:48

GoogleCodeExporter commented 9 years ago 
Worked in a basic patch into 10.0.5 and it is 1-2% faster. It passes all tests 
and is very safe (since ASSERT() is a no-op without DEBUG), so we will ship it 
now, and for unstable in 14.

Original comment by classi...@floodgap.com on 1 Jun 2012 at 4:26

GoogleCodeExporter commented 9 years ago 
Actually, thinking about it, since this removes an ASSERT() (even a dead one), 
we should probably hold off on it. But the patch works.

Original comment by classi...@floodgap.com on 1 Jun 2012 at 4:38

GoogleCodeExporter commented 9 years ago

Original comment by classi...@floodgap.com on 1 Jun 2012 at 4:39

Attachments:

GoogleCodeExporter commented 9 years ago 
test build generated for 7450 only

Original comment by classi...@floodgap.com on 2 Jun 2012 at 6:01

GoogleCodeExporter commented 9 years ago 
Shipp'd

Original comment by classi...@floodgap.com on 17 Jul 2012 at 1:59