search

keeleysam / tenfourfox

Automatically exported from code.google.com/p/tenfourfox
0 stars 0 forks source link

Fx16: No audio output in Aurora 16 #172

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When trying to play any audio content (pure audio or video with embedded audio) 
I only hear one click sound in the beginning and silence for the rest of the 
time.

Original issue reported on code.google.com by Tobias.N...@gmail.com on 18 Jul 2012 at 7:04

GoogleCodeExporter commented 9 years ago 
Could be libcubeb. Is it enabled?

Original comment by classi...@floodgap.com on 18 Jul 2012 at 7:21

GoogleCodeExporter commented 9 years ago 
(And I suspect it *is* libcubeb:

https://bugzilla.mozilla.org/show_bug.cgi?id=768265

). We should be able to disable it in the interim unless you can fix it. The 
backside code for OS X should be

https://bugzilla.mozilla.org/show_bug.cgi?id=742160

Original comment by classi...@floodgap.com on 18 Jul 2012 at 7:24

GoogleCodeExporter commented 9 years ago 
Thanks for the hint - it was indeed an endian issue in libcubeb, which I was 
able to fix by looking at libsydneyaudio.

Original comment by Tobias.N...@gmail.com on 18 Jul 2012 at 7:47

Attachments:

GoogleCodeExporter commented 9 years ago 
We should upstream this.

Original comment by classi...@floodgap.com on 18 Jul 2012 at 8:27

GoogleCodeExporter commented 9 years ago 
in "media/libcubeb/include/cubeb.h" there is the following section:
{{{
#ifdef WORDS_BIGENDIAN
  /**< Native endian 16-bit signed PCM. */
  CUBEB_SAMPLE_S16NE = CUBEB_SAMPLE_S16BE,
  /**< Native endian 32-bit IEEE floating point PCM. */
  CUBEB_SAMPLE_FLOAT32NE = CUBEB_SAMPLE_FLOAT32BE
#else
  /**< Native endian 16-bit signed PCM. */
  CUBEB_SAMPLE_S16NE = CUBEB_SAMPLE_S16LE,
  /**< Native endian 32-bit IEEE floating point PCM. */
  CUBEB_SAMPLE_FLOAT32NE = CUBEB_SAMPLE_FLOAT32LE
#endif
}}}
I don't check this but I suspect WORDS_BIGENDIAN isn't defined (correctly).

Original comment by Tobias.N...@gmail.com on 27 Jul 2012 at 10:38

GoogleCodeExporter commented 9 years ago 
I meant I "didn't" instead of "don't".

Original comment by Tobias.N...@gmail.com on 27 Jul 2012 at 10:54

GoogleCodeExporter commented 9 years ago 
I suggest the following patch (doesn't break anything):

--- a/media/libcubeb/include/cubeb.h    Mon Jul 23 13:19:43 2012 +0200
+++ b/media/libcubeb/include/cubeb.h    Fri Jul 27 16:03:06 2012 +0200
@@ -89,7 +89,7 @@
   CUBEB_SAMPLE_FLOAT32LE,
   /**< Big endian 32-bit IEEE floating point PCM. */
   CUBEB_SAMPLE_FLOAT32BE,
-#ifdef WORDS_BIGENDIAN
+#if defined(WORDS_BIGENDIAN) || defined(__BIG_ENDIAN__)
   /**< Native endian 16-bit signed PCM. */
   CUBEB_SAMPLE_S16NE = CUBEB_SAMPLE_S16BE,
   /**< Native endian 32-bit IEEE floating point PCM. */

Original comment by Tobias.N...@gmail.com on 27 Jul 2012 at 2:10

GoogleCodeExporter commented 9 years ago 
This bug has been files to mozilla:
https://bugzilla.mozilla.org/show_bug.cgi?id=779187

Original comment by Tobias.N...@gmail.com on 31 Jul 2012 at 4:56

GoogleCodeExporter commented 9 years ago 
Closing as fixed; this works properly in 17.

Original comment by classi...@floodgap.com on 18 Sep 2012 at 4:15