search

keeleysam / tenfourfox

Automatically exported from code.google.com/p/tenfourfox
0 stars 0 forks source link

Disable plugins completely to avoid crashes #185

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Per Tobias in issue 181, the end of 10.5 support causes plugins to crash. To 
prevent users who have the setting enabled from this, plugins will be turned 
off irrevocably in 18.

Original issue reported on code.google.com by classi...@floodgap.com on 12 Oct 2012 at 10:32

GoogleCodeExporter commented 9 years ago 
FTR, https://bugzilla.mozilla.org/show_bug.cgi?id=598401 was the breaker. This 
was expected, however; they've planned to remove QuickDraw support for some 
time.

Original comment by classi...@floodgap.com on 12 Oct 2012 at 11:50

GoogleCodeExporter commented 9 years ago 
Aaaand this one: https://bugzilla.mozilla.org/show_bug.cgi?id=598397
The axe has fallen.

Original comment by classi...@floodgap.com on 13 Oct 2012 at 12:03

GoogleCodeExporter commented 9 years ago 
Looking at both changes gives the impression that Carbon plugins (Flash and 
QuickTime do use Carbon APIs) *should* still work in 18. 598401 does remove 
QuickDraw API support only and 598397 wasn't landed yet. Actually plugins might 
still work in TenFourFox... after all the CoreGraphics azure backend cannot be 
used as is in AuoraFox because the CoreGraphics context ref seems to get lost 
(or isn't initialized) somehow.

Original comment by Tobias.N...@gmail.com on 14 Oct 2012 at 8:47

GoogleCodeExporter commented 9 years ago 
Maybe, but I'm certainly not going to test or support that. They're clearly 
marked for destruction and this is a good time to do it.

But I don't understand why the CG Azure backend goes wrong in AuroraFox. It's 
all 10.5-compatible APIs. Does the TenFourFox Tiger version work better?

Original comment by classi...@floodgap.com on 14 Oct 2012 at 9:57

GoogleCodeExporter commented 9 years ago 
Got the CG Azure backend working (actually GetNativeSurface() in 
DrawTarget2D.cpp is buggy and doesn't return the CGContextRef when IOSurface is 
unavailable).
But it does perform slightly worse than the Skia backend here, benchmarking 
with this test: http://www.kevs3d.co.uk/dev/asteroidsbench/ .

So far I couldn't get the QuickTime plugin to not crash. I even applied the 
patch from 598397 and made NP_NO_QUICKDRAW and NP_NO_CARBON to be always 
defined.

Original comment by Tobias.N...@gmail.com on 18 Oct 2012 at 9:54

GoogleCodeExporter commented 9 years ago 
A variety of the fix for issue 188 will also be needed.

Original comment by classi...@floodgap.com on 5 Nov 2012 at 2:47

GoogleCodeExporter commented 9 years ago

Original comment by classi...@floodgap.com on 17 Dec 2012 at 6:20

GoogleCodeExporter commented 9 years ago 
Actually the plugin crashes are mostly gone in 19 now - they simply don't work. 
In AuroraFox I modified the blacklist to mark those plugins as broken.

Original comment by Tobias.N...@gmail.com on 12 Jan 2013 at 9:24

GoogleCodeExporter commented 9 years ago 
Closing as done, since it is

Original comment by classi...@floodgap.com on 13 Jan 2013 at 5:29