Some Command-shortcuts do not work

[GoogleCodeExporter]

-- 8< CUT EVERYTHING UP TO AND INCLUDING THIS LINE FROM YOUR REPORT 8< --

* I read everything above and have demonstrated this bug only occurs on
10.4Fx by testing against this official version of Firefox 4 (not
applicable for startup failure) - specify:

TenFourFx Beta 9

* This is a startup crash or failure to start (Y/N):

No

* What steps are necessary to reproduce the bug? These must be reasonably 
reliable.

Daily use. As far as I know:
"Cmd + a number" to switch to the corresponding tab doesn't work.
"Cmd + + ", press it once, firefox zooms for four times.
"Cmd + Enter" in the location bar doesn't auto-complete "www.*.com"

* Describe your processor, computer, operating system and any special
things about your environment.

G5/PowerPC 970 1.8 GHz, iMac, 10.5.8

* If this is a startup crash or failure to start, have you tried restarting 
with a clean profile? Does this fix the problem?

Clean profile doesn't fix it.

Thanks for your help!

Thanks for developing TenFourFx.

Original issue reported on code.google.com by leikka...@gmail.com on 18 Jan 2011 at 10:49

[GoogleCodeExporter]

Just as a note, when using the report form, please make sure that during the 
test phase it was tested against official Firefox 4b9 (TenFourFox is an 
unofficial build).

However, I do confirm the following:

Cmd + # does not work for tab switches
Cmd + enter does not turn xxx into www.xxx.com

I am unable to duplicate the zoom issue, it seems to work correctly for me on 
my quad G5, 10.4.11. However, I'll mark Accepted on the other two.

Original comment by classi...@floodgap.com on 18 Jan 2011 at 6:58

• Changed title: Some Command-shortcuts do not work
• Changed state: Accepted
• Added labels: Priority-Medium

[GoogleCodeExporter]

Thank you. Tested the shortcuts today on Windows. They are fine.

I have no Intel mac so I cannot test the official mac build. :)

The zoon issue is, perhaps, specific to OS X 10.5 ?

Original comment by leikka...@gmail.com on 19 Jan 2011 at 4:02

[GoogleCodeExporter]

Ah. In that case, just specify that in your bug reports.

It's quite possible it's a 10.5-specific issue; I'm doing my work and testing 
almost all on 10.4. I'd be interested to hear if other 10.5 users see it, or 
10.4. The other two I can see, so I will work on that in the meantime.

Original comment by classi...@floodgap.com on 19 Jan 2011 at 5:17

[GoogleCodeExporter]

I suspect the hack in nsMenuBarX::performKeyEquivalent is the culprit. We may 
need to hoist some code up.

Original comment by classi...@floodgap.com on 30 Jan 2011 at 4:38

[GoogleCodeExporter]

report: the shortcuts remain in beta 11 :)

Original comment by leikka...@gmail.com on 3 Feb 2011 at 5:45

[GoogleCodeExporter]

remain broken* oops :)

Original comment by leikka...@gmail.com on 3 Feb 2011 at 7:45

[GoogleCodeExporter]

I know, that's why it's not marked Fixed ;)

Upgrading to high, it would be nice to have for beta 12.

Original comment by classi...@floodgap.com on 5 Feb 2011 at 5:23

• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Oh, thank you. I didn't know about the "fixed" tag.

Original comment by leikka...@gmail.com on 6 Feb 2011 at 11:59

[GoogleCodeExporter]

This turned out to be a very complex fix even though the fix itself wasn't very 
long. nsMenuBarX was not the actual culprit although I had to undo my previous 
fix for menu key combinations for this to work. The actual fix was in 
nsChildView.mm adding a -performKeyEquivalent like 3.6 had. However, simply 
forwarding all the events to -pKE to -keyDown caused anything with an 
NSFunctionKeyMask bit (arrow keys, function keys, etc.), to generate spurious 
double events and made those keys unusable even though Cmd-sequences now 
started working. After some experimentation with special cases in -keyDown, the 
correct solution was simply to return NO in -pKE for anything that wasn't a 
Command-key sequence (and for Command-key, to forward that to -keyDown and 
return YES).

I still cannot find anything wrong with Cmd-+ but this will appear in beta 12 
so you can tell me if it fixes it.

verified (for 10.4)

Original comment by classi...@floodgap.com on 12 Feb 2011 at 6:51

• Changed state: Verified

[GoogleCodeExporter]

Issue 29 has been merged into this issue.

Original comment by classi...@floodgap.com on 12 Feb 2011 at 3:49

[GoogleCodeExporter]

Issue 30 has been merged into this issue.

Original comment by classi...@floodgap.com on 12 Feb 2011 at 3:49

[GoogleCodeExporter]

This caused issue 33.

Original comment by classi...@floodgap.com on 26 Feb 2011 at 12:46