search

keeleysam / tenfourfox

Automatically exported from code.google.com/p/tenfourfox
0 stars 0 forks source link

Default gfx.color_management.profilev4 to true for better colour fidelity #225

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Uplift from 
http://tenfourfox.tenderapp.com/discussions/problems/394-color-profiling-not-wor
king

We might need to instrument the code in 
https://bugzilla.mozilla.org/show_bug.cgi?id=514932 or roll it back.

Original issue reported on code.google.com by classi...@floodgap.com on 19 May 2013 at 6:46

GoogleCodeExporter commented 9 years ago 
In gfx/thebes/gfxPlatform.cpp, we try sRGB first (if 
gfx.color_management.force_srgb is true), then try to load any specified 
profile, then try to load the platform profile. If the platform profile is 
bogus, assume sRGB. We should be able to see by enabling DEBUG_tor in 
gfxPlatformMac::GetPlatformCMSOutputProfile() whether it actually can load it.

Original comment by classi...@floodgap.com on 19 May 2013 at 7:02

GoogleCodeExporter commented 9 years ago 
We should also make sure that the gamma seen by qcms is, indeed, 1.8.

Original comment by classi...@floodgap.com on 19 May 2013 at 7:07

GoogleCodeExporter commented 9 years ago 
Image from reporter (NSFW): 
http://photos.modelmayhem.com/photos/090416/11/49e77a949088d.jpg

Original comment by classi...@floodgap.com on 19 May 2013 at 7:09

GoogleCodeExporter commented 9 years ago 
Adding some instrumentation, the Huey profile on the G5 appears to load:

CMGetProfileByAVID
NCMGetProfileLocation
NCMGetProfileLocation ok
ICM profile read from /home/spectre/Library/ColorSync/Profiles/huey Unnamed Mo 
fileLoc successfully

The Huey profile doesn't have a gamma value; it has direct colour sampling. The 
Generic RGB Profile does have a gamma of 1.8.

Original comment by classi...@floodgap.com on 19 May 2013 at 7:35

GoogleCodeExporter commented 9 years ago 
Setting gfx.color_management.enablev4 to true fixes the problem (Preview and 
TenFourFox are identical for the huey profile).

Original comment by classi...@floodgap.com on 19 May 2013 at 7:47

GoogleCodeExporter commented 9 years ago 
With this enabled for Generic RGB, the image is better, though does not quite 
match Preview.

Original comment by classi...@floodgap.com on 19 May 2013 at 7:48

GoogleCodeExporter commented 9 years ago 
Adam, when you look at this bug, please report in whether toggling that setting 
has an effect for you.

Original comment by classi...@floodgap.com on 19 May 2013 at 7:49

GoogleCodeExporter commented 9 years ago 
There is a bug with enabling V4 profiles (M722831). This bug did not land on 
ESR, so ESR will need that also:

https://hg.mozilla.org/releases/mozilla-beta/rev/4cee1607a72e

Original comment by classi...@floodgap.com on 19 May 2013 at 7:54

GoogleCodeExporter commented 9 years ago

Original comment by classi...@floodgap.com on 19 May 2013 at 7:54

GoogleCodeExporter commented 9 years ago 
Also, https://bugzilla.mozilla.org/show_bug.cgi?id=739785

Original comment by classi...@floodgap.com on 19 May 2013 at 8:36

GoogleCodeExporter commented 9 years ago 
Pref toggled in 22.

Original comment by classi...@floodgap.com on 20 May 2013 at 4:45

GoogleCodeExporter commented 9 years ago 
The test image from Tender is displayed correctly in TFF 21 if 
gfx.color_management.enablev4 is set to true. I see you already discovered it 
yourself, this is just to confirm it also works on 10.5. Also 
color.org/version4html.xalter renders with four correct quadrants.

Original comment by chtru...@web.de on 21 May 2013 at 9:53

GoogleCodeExporter commented 9 years ago 
Excellent. Scheduled for 17.0.7/22 then.

Original comment by classi...@floodgap.com on 21 May 2013 at 11:42

GoogleCodeExporter commented 9 years ago 
Both changes checked into 17.0.7

Original comment by classi...@floodgap.com on 20 Jun 2013 at 5:45

GoogleCodeExporter commented 9 years ago 
Checked into 22.0

Original comment by classi...@floodgap.com on 23 Jun 2013 at 8:21