keeleysam / tenfourfox

Automatically exported from code.google.com/p/tenfourfox
0 stars 0 forks source link

Make dom.max_script_run_time 40 #227

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Getting more timeouts with 22, possibly due to multithreading interactions.

Original issue reported on code.google.com by classi...@floodgap.com on 2 Jun 2013 at 5:34

GoogleCodeExporter commented 9 years ago
Landed in 22.0

Original comment by classi...@floodgap.com on 23 Jun 2013 at 8:28

GoogleCodeExporter commented 9 years ago

Original comment by classi...@floodgap.com on 9 Jul 2013 at 2:01

GoogleCodeExporter commented 9 years ago
After some comments on Facebook (PPC group/LEM group) about JS "errors" with 
TFF (i.e. the slow script warning), and some testing of my own, I can say that 
neither a value of 10 nor 20 is enough for using FB. People are more and more 
likely to see the warning – either FB is becoming more JS heavy, or 17 and up 
(and still worse in 22) trigger it more often. I recommend a value of 40, if 
possible. If I use this, I hardly ever get to see the message, and I use 
Facebook a lot.
TFF 22, PB G4 1.33 GHz.

Original comment by chtru...@web.de on 29 Aug 2013 at 6:38

GoogleCodeExporter commented 9 years ago
If you think that's reasonable, we'll do that for 22.0.2/24.

Original comment by classi...@floodgap.com on 30 Aug 2013 at 3:11

GoogleCodeExporter commented 9 years ago
I think we'd avoid some TenderApp tickets this way, and it doesn't seem to have 
any negative effects, so I guess it's reasonable. Facebook is usable on a 
typical G4 machine with no interference this way, and the warning will still 
pop up if JS is stuck severely before people force-quit.

Original comment by chtru...@web.de on 30 Aug 2013 at 10:34

GoogleCodeExporter commented 9 years ago
Landed in 22.0.2

Original comment by classi...@floodgap.com on 19 Sep 2013 at 1:16

GoogleCodeExporter commented 9 years ago
Verified. For further extensions, we'll create a new issue.

Original comment by classi...@floodgap.com on 22 Sep 2013 at 2:54