search

keeleysam / tenfourfox

Automatically exported from code.google.com/p/tenfourfox
0 stars 0 forks source link

Fix updater in 22 #228

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Either a bad patch or our code bollixed it, but Check for Updates ends with

Timestamp: 6/4/13 8:09:04 PM
Error: ReferenceError: checkForUpdates is not defined
Source File: chrome://browser/content/hiddenWindow.xul
Line: 1

Original issue reported on code.google.com by classi...@floodgap.com on 5 Jun 2013 at 3:08

GoogleCodeExporter commented 9 years ago 
So we're missing something.

bruce:/home/spectre/src/bruce/mozilla-22b/browser/base/% grep -r 
checkForUpdates *
content/aboutDialog.js:    
this.checker.checkForUpdates(this.updateCheckListener, true);
content/aboutDialog.js:    
this.checker.checkForUpdates(this.updateCheckListener, true);
content/baseMenuOverlay.xul:        <menuitem id="checkForUpdates"
content/baseMenuOverlay.xul:                  oncommand="checkForUpdates();"/>
content/browser-plugins.js:        let updateLink = 
doc.getAnonymousElementByAttribute(plugin, "class", "checkForUpdatesLink");
content/test/browser_pluginnotification.js:  var updateLink = 
doc.getAnonymousElementByAttribute(plugin, "class", "checkForUpdatesLink");
content/test/browser_pluginnotification.js:  var updateLink = 
doc.getAnonymousElementByAttribute(plugin, "class", "checkForUpdatesLink");
content/urlbarBindings.xml:          <xul:label xbl:inherits="href=updateLink" 
value="&checkForUpdates;" class="text-link"/>

bruce:/home/spectre/src/bruce/mozilla-22b/browser/base/% pushd 
../../../mozilla-21.0/browser/base/
~/src/bruce/mozilla-21.0/browser/base ~/src/bruce/mozilla-22b/browser/base 
~/src/bruce/mozilla-22b/js/src/ion

bruce:/home/spectre/src/bruce/mozilla-21.0/browser/base/% grep -r 
checkForUpdates *
content/aboutDialog.js:    
this.checker.checkForUpdates(this.updateCheckListener, true);
content/aboutDialog.js:    
this.checker.checkForUpdates(this.updateCheckListener, true);
content/baseMenuOverlay.xul:        <menuitem id="checkForUpdates"
content/baseMenuOverlay.xul:                  oncommand="checkForUpdates();"/>
content/browser-plugins.js:        let updateLink = 
doc.getAnonymousElementByAttribute(plugin, "class", "checkForUpdatesLink");
content/test/browser_pluginnotification.js:  var updateLink = 
doc.getAnonymousElementByAttribute(plugin, "class", "checkForUpdatesLink");
content/test/browser_pluginnotification.js:  var updateLink = 
doc.getAnonymousElementByAttribute(plugin, "class", "checkForUpdatesLink");
content/urlbarBindings.xml:          <xul:label xbl:inherits="href=updateLink" 
value="&checkForUpdates;" class="text-link"/>
content/utilityOverlay.js:function checkForUpdates()
content/utilityOverlay.js:    prompter.checkForUpdates();
content/utilityOverlay.js:function setupCheckForUpdates(checkForUpdates, 
aStringBundle)
content/utilityOverlay.js:  checkForUpdates.setAttribute("disabled", 
!canCheckForUpdates);
content/utilityOverlay.js:  checkForUpdates.label = 
getStringWithUpdateName("updatesItem_" + key);
content/utilityOverlay.js:  checkForUpdates.accessKey = aStringBundle.
content/utilityOverlay.js:    checkForUpdates.setAttribute("loading", "true");
content/utilityOverlay.js:    checkForUpdates.removeAttribute("loading");
content/utilityOverlay.js:  var checkForUpdates = 
document.getElementById("checkForUpdates");
content/utilityOverlay.js:  setupCheckForUpdates(checkForUpdates, 
browserBundle);

And it does indeed look like we're missing a patch (from 21exports 132711).

Original comment by classi...@floodgap.com on 22 Jun 2013 at 3:41

GoogleCodeExporter commented 9 years ago 
Landed

Original comment by classi...@floodgap.com on 23 Jun 2013 at 9:02

GoogleCodeExporter commented 9 years ago

Original comment by classi...@floodgap.com on 24 Jun 2013 at 12:35