Worklist for 29

[GoogleCodeExporter]

1. Endian problem with icon images?
2. Snapshot thumbnails use ContentParent and crash
3. Snapshot thumbnails have a weird blue tint (probably also endian) (issue 236)
4. Issue 247
5. Fix background colour of windows
6. Remove spurious resize gadget at bottom of window bar
7. See if mAvailableFonts goes bad other places, probably fallout from 
disabling the deferred font loader

Original issue reported on code.google.com by classi...@floodgap.com on 24 Mar 2014 at 3:44

• Blocked on: #236

[GoogleCodeExporter]

Disabled tab thumbnails on background threads through newTab.js. They still 
have a weird tint though.

Original comment by classi...@floodgap.com on 25 Mar 2014 at 1:41

[GoogleCodeExporter]

Interestingly, in full screen the background colour is CORRECT.

Original comment by classi...@floodgap.com on 25 Mar 2014 at 1:42

[GoogleCodeExporter]

8. Change default font size to 14 to match previous versions (apparently it's 
optimizing for HiDPI)

Original comment by classi...@floodgap.com on 25 Mar 2014 at 1:59

[GoogleCodeExporter]

Printing works, too.

Original comment by classi...@floodgap.com on 25 Mar 2014 at 2:33

[GoogleCodeExporter]

9. ColorPicker bug:
++DOMWINDOW == 79 (0x2fb4ae84) [pid = 18120] [serial = 165] [outer = 0x2fa77684]
2014-03-24 19:59:45.456 firefox[18120] Mozilla has caught an Obj-C exception 
[NSInvalidArgumentException: *** -getRed:green:blue:alpha: not defined for the 
NSColor NSCalibratedWhiteColorSpace 0 1; need to first convert colorspace.]

Original comment by classi...@floodgap.com on 25 Mar 2014 at 3:00

[GoogleCodeExporter]

So far no other font crashes.

Original comment by classi...@floodgap.com on 25 Mar 2014 at 3:09

[GoogleCodeExporter]

The thumbnail protocol is the bad part:

moz-page-thumb://thumbnail?url=http%3A%2F%2Fwww.mozilla.org%2Fen-US%2F

Original comment by classi...@floodgap.com on 25 Mar 2014 at 3:16

[GoogleCodeExporter]

... and this does work in 24

Original comment by classi...@floodgap.com on 25 Mar 2014 at 3:18

[GoogleCodeExporter]

Forcing on CG instead of Cairo doesn't fix it, though I'm pleasantly surprised 
to note that CG is now a lot faster than it was in 26 and there are 
considerably fewer context errors (I think my merge fixed it). We're still 
going to use Cairo though.

Ran into
[20047] ###!!! ABORT: Should be tracking any image we're going to use!: 
'mImageTracked', file 
/Volumes/BruceDeuce/src/mozilla-29a/layout/generic/../style/nsStyleStruct.h, 
line 208
on Apple.com. We could always disable the assert at runtime.

but this seems to be known
https://bugzilla.mozilla.org/show_bug.cgi?id=975397

Original comment by classi...@floodgap.com on 25 Mar 2014 at 3:43

[GoogleCodeExporter]

Thumbnails also worked in 26, so this was done in 27, 28 or 29

Original comment by classi...@floodgap.com on 25 Mar 2014 at 3:58

[GoogleCodeExporter]

In content/canvas/src/CanvasRenderingContext2D.cpp -> 
CanvasRenderingContext2D::GetImageDataArray, don't byte swap??

Original comment by classi...@floodgap.com on 25 Mar 2014 at 4:09

[GoogleCodeExporter]

https://bugzilla.mozilla.org/show_bug.cgi?id=851652 should give us some ideas 
about issue 247.

Original comment by classi...@floodgap.com on 26 Mar 2014 at 4:28

[GoogleCodeExporter]

Color management is wrecked.

Original comment by classi...@floodgap.com on 27 Mar 2014 at 2:59

[GoogleCodeExporter]

getUserMedia web cam support does not appear on screen.
This is just getting worse and worse.

Original comment by classi...@floodgap.com on 27 Mar 2014 at 4:21

[GoogleCodeExporter]

drawWindow does not have any endian problems, tested with a background 
thumbnail extension, so it can't be that (comment 11).

Original comment by classi...@floodgap.com on 27 Mar 2014 at 5:16

[GoogleCodeExporter]

Finally found the source of the mangled menu icons -- 
https://bugzilla.mozilla.org/show_bug.cgi?id=888689 . Backed out.

Original comment by classi...@floodgap.com on 28 Mar 2014 at 4:04

[GoogleCodeExporter]

Fullscreen close button isn't showing either.
Looks like nsChildView::MaybeDrawTitlebar should do this, plus our traffic 
light buttons.

Original comment by classi...@floodgap.com on 28 Mar 2014 at 4:38

[GoogleCodeExporter]

Private browsing windows have *correct* chrome. So we will fix this by changing 
the theme.

Need to also fix the line across the top of the window, it's black instead of 
white.

Original comment by classi...@floodgap.com on 28 Mar 2014 at 4:47

[GoogleCodeExporter]

Fixed line. But changing #main-window in browser.css doesn't fix the problem 
(more accurately, it makes it active all the time). The private browsing window 
*does* respond right, so it's something about the difference between the two.

Original comment by classi...@floodgap.com on 28 Mar 2014 at 5:08

[GoogleCodeExporter]

Found it. We had to manually specify the inactive theme also. Now it works 
properly.

Fixed so far:
- No more font crashes
- No more thumbnail crashes
- Icons in menus no longer scrambled
- Basic window appearance is correct

Things we want to fix before migrating to beta:
- Webcam
- Blue tint thumbnails
- Colour picker
- Colour management

Things we will fix after:
- New baseline prefs (14 point font, our optimized GC prefs)
- Traffic light buttons (not fixed by our HITheme code) (but is 
hoverable/clickable)
- Full screen button not appearing in full screen mode (but is clickable, not 
hoverable)
- Resize gadget (maybe our HITheme code is doing this)

Original comment by classi...@floodgap.com on 28 Mar 2014 at 5:21

[GoogleCodeExporter]

Clicking on icons in the Preferences window makes them highlight weirdly 
instead of darken.

Original comment by classi...@floodgap.com on 28 Mar 2014 at 5:24

[GoogleCodeExporter]

The resize gadget was coming from our HITheme code. Strange it drew that, but 
not the traffic light buttons. Removed.

Original comment by classi...@floodgap.com on 30 Mar 2014 at 3:52

[GoogleCodeExporter]

Colour management fixed (passing the wrong pointer). Still don't know what's up 
with the blue tint.

Colour picker next, then webcam. If we fix these and can't find the endian 
problem with thumbnails, upgrade anyway.

Original comment by classi...@floodgap.com on 30 Mar 2014 at 6:40

[GoogleCodeExporter]

Colour picker works.

Original comment by classi...@floodgap.com on 2 Apr 2014 at 3:03

[GoogleCodeExporter]

Webcam works for video only, but only if I disable checking the frame 
timestamp. Shippable but ugly.

Audio doesn't work, even built-in.

Audio/video doesn't even work for video (blank box).

Original comment by classi...@floodgap.com on 3 Apr 2014 at 4:38

[GoogleCodeExporter]

Audio playback is fine in WebM, but it looks like WebRTC does its own screwing 
around with the microphone and speakers.

Original comment by classi...@floodgap.com on 3 Apr 2014 at 4:41

[GoogleCodeExporter]

Audio doesn't seem to work in 26 either, so that narrows our regression range a 
bit.

Original comment by classi...@floodgap.com on 5 Apr 2014 at 1:26

[GoogleCodeExporter]

When checking RecordingIsAvailable,

MEMORY    ; (21: 7:44:218 |    0) AUDIO DEVICE:    1    99;     52231; 
AudioDeviceBuffer::SetRecordingSampleRate(fsHz=48000)
MEMORY    ; (21: 7:44:218 |    0) AUDIO DEVICE:    1    99;     52231; 
AudioDeviceBuffer::SetRecordingChannels(channels=2)
STATEINFO ; (21: 7:44:219 |    1)      UTILITY:         -1;     61383; Thread 
with name:CaptureWorkerThread started 
DEBUG     ; (21: 7:44:241 |   22) AUDIO DEVICE:    1    99;     87555;  
Recording device stopped
DEBUG     ; (21: 7:44:241 |    0) AUDIO DEVICE:    1    99;     52231;  
Recording stopped
STATEINFO ; (21: 7:44:259 |   18)      UTILITY:         -1;     61383; Thread 
with name:CaptureWorkerThread stopped
STATEINFO ; (21: 7:44:261 |    2) AUDIO DEVICE:    1    99;     52231; output: 
available=1
STATEINFO ; (21: 7:44:261 |    0)        VOICE:    1    99;     52231;   
Output: isAvailable = 1)

the CaptureWorkerThread does not seem to get restarted.

Original comment by classi...@floodgap.com on 7 Apr 2014 at 4:24

[GoogleCodeExporter]

Fixed the traffic light buttons by twiddling the context rect and using 
HIThemeDrawTitleBarWidget instead.

Original comment by classi...@floodgap.com on 19 Apr 2014 at 5:19

[GoogleCodeExporter]

AltiVec build started up. Works well. VPX is a little slower than 24 but still 
fine. (Could be because the G5 is running two browsers at the same time.)

What still doesn't work:
- Tab Groups doesn't come up at all. Mozilla is considering removing this. This 
is a good time to do so.
- Thumbnails still tinted blue. I might disable these entirely since we don't 
support asynchronous thumbnails.
- Voice and video with audio in gUM.

The new Google Maps also doesn't work right, but I think this is Mozilla's bug, 
and the old one still works fine.
None of these are show-stoppers.

What needs to still be fixed:
- Session Store throws errors, looks like the old synchronous interface is 
gone. (This might also be the cause of Tab Groups going bad.)
- Wordmark shows Firefox Nightly.
- See if we can adjust the white line bevel beneath the tab bar.
- Clicking on icons in Preferences window makes them blow out white.

Original comment by classi...@floodgap.com on 19 Apr 2014 at 8:36

[GoogleCodeExporter]

Fixed session store (by backing out our issue 210 fix and a minor tweak), but 
that doesn't fix Tab Groups. So they're gone.

Original comment by classi...@floodgap.com on 19 Apr 2014 at 9:23

[GoogleCodeExporter]

NVM -- it works from the hamburger menu, but not the main interface. Whatever. 
Session store's tweak does fix that too.

Original comment by classi...@floodgap.com on 19 Apr 2014 at 9:28

[GoogleCodeExporter]

Bevel line darkened by stealing a line from lwtheme, where it does appear 
correctly. (It also turns out that 29 still suffers from issue 247, so that was 
some other cause.) Also fixed wordmark. Now let's see what we can do about the 
prefs window.

Original comment by classi...@floodgap.com on 19 Apr 2014 at 10:15

[GoogleCodeExporter]

Original comment by classi...@floodgap.com on 19 Apr 2014 at 10:15

[GoogleCodeExporter]

The blown out icons in Preferences looks like an SVG filter issue. Wanna bet 
it's an endian problem?

Original comment by classi...@floodgap.com on 20 Apr 2014 at 2:44

[GoogleCodeExporter]

Many SVG filters aren't showing up at all. I wonder if this is our problem with 
Google Maps.

On the plus side, while checking things, our CG-based Azure and canvas 
implementation is working great and seems to be a smidge faster.

Original comment by classi...@floodgap.com on 20 Apr 2014 at 3:08

[GoogleCodeExporter]

... but it just crashed, so we'll stick with Cairo. It's not the problem 
anyway, Cairo should work.

Original comment by classi...@floodgap.com on 20 Apr 2014 at 3:26

[GoogleCodeExporter]

Swapping the bit order in SourceSurfaceCG.cpp didn't work, it just made it bad.

Original comment by classi...@floodgap.com on 20 Apr 2014 at 4:41

[GoogleCodeExporter]

It's FilterProcessing.h. It has constants, but the wrong one. Now they are 
fixed. https://bugzilla.mozilla.org/show_bug.cgi?id=998749

Original comment by classi...@floodgap.com on 20 Apr 2014 at 5:44

[GoogleCodeExporter]

That fixes the blown out icons and SVG filters now work properly, but Google 
Maps New doesn't improve.

Original comment by classi...@floodgap.com on 20 Apr 2014 at 5:45

[GoogleCodeExporter]

Private browsing windows don't show the traffic light buttons either, but we 
can probably change this in the CSS.

Original comment by classi...@floodgap.com on 20 Apr 2014 at 5:59

[GoogleCodeExporter]

(That's not a new problem -- it happens in 24 also, but no one noticed.)

Original comment by classi...@floodgap.com on 20 Apr 2014 at 8:41

[GoogleCodeExporter]

The new tab button is missing now. It used to appear. Did our change to 
browser.css make that disappear?

Original comment by classi...@floodgap.com on 20 Apr 2014 at 9:05

[GoogleCodeExporter]

No, it was Classic Theme Restorer; I forgot we moved the new tab button over.

Plus, I like the title bar restore option. I didn't notice that before. Yay!

Original comment by classi...@floodgap.com on 21 Apr 2014 at 3:10

[GoogleCodeExporter]

Fixed private browsing by just making them use moz-titlebar. That won't work 
for lwtheme, but that's still issue 247's problem.

Original comment by classi...@floodgap.com on 21 Apr 2014 at 3:59

[GoogleCodeExporter]

The endian problem with thumbnails was introduced in bug 933030: 
https://bugzilla.mozilla.org/show_bug.cgi?id=933030

If we put back the old Thebes code, it works (for GetImageBuffer). So we need 
to debug gfx/2d/DataSurfaceHelpers.h's SurfaceToPackedBGRA, or we can ship the 
Thebes code, I guess.

Original comment by classi...@floodgap.com on 23 Apr 2014 at 4:33

[GoogleCodeExporter]

If we decide to ship the Thebes code for 31, we'll need to back out 991572 at 
the same time, since it removes GetThebesSurface() (or we add something to do 
the call within GetImageBuffer).

Original comment by classi...@floodgap.com on 23 Apr 2014 at 5:28

[GoogleCodeExporter]

Also check https://bugzilla.mozilla.org/show_bug.cgi?id=752394 for 31

Original comment by classi...@floodgap.com on 23 Apr 2014 at 5:48

[GoogleCodeExporter]

Remaining problem: canvas doesn't update (Google Maps, 
https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Canvas_tutorial/Basic_an
imations )

So far traced this to only finding a BasicCanvasLayer. We need a 
ClientCanvasLayer, apparently, to hook it up to the right Thebes surface so it 
can draw.

Original comment by classi...@floodgap.com on 28 Apr 2014 at 3:44

[GoogleCodeExporter]

Actually, we can use a BasicCanvasLayer. We do get a gfxContext we can draw to 
that's in the right place. So somehow we're not painting it, and that code is 
in CopyableCanvasLayer::PaintWithOpacity(). We do get a surface (we can even 
right click on it and select it) and we do have a context. So why won't it draw?

Original comment by classi...@floodgap.com on 28 Apr 2014 at 5:07