search

keeleysam / tenfourfox

Automatically exported from code.google.com/p/tenfourfox
0 stars 0 forks source link

[ChildView drawRect:inTitlebarContext:] has been obsoleted but still used in nsCococaWindow.mm [NPOTB?] #273

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
-- 8< CUT EVERYTHING UP TO AND INCLUDING THIS LINE FROM YOUR REPORT 8< --

* I read everything above and have demonstrated this bug only occurs on
10.4Fx by testing against this official version of Firefox 4/up (not
applicable for startup failure) - SPECIFY VERSION YOU TESTED AGAINST:

* Layout bugs MUST be tested against a system WITHOUT hardware
acceleration. Go to Help, Troubleshooting Information to see if your test
system is accelerated. If your test system IS accelerated, you must make
sure it is OFF, OR test on ANOTHER system that isn't. If this is NOT a
layout or display bug, you can skip this step.

* This is a startup crash or failure to start (Y/N):
No

* This is a fault of JavaScript acceleration (Y/N): (Use the steps above to
find out. Do NOT report if it is not.)
No

* What steps are necessary to reproduce the bug? These must be reasonably
reliable.
* Describe your processor, computer, operating system and any special
things about your environment.

See: http://sourceforge.jp/projects/tenfourbird/forums/28579/35080/

* If this is a startup crash or failure to start, have you tried restarting
with a clean profile or in safe mode? Does this fix the problem?

* For crashes or startup failure (optional): paste in any information from
Crash Reporter, or if you are able to run 10.4Fx in gdb, paste in the
backtrace. You can often do it like this from within Terminal.app:

cd appname.app/Contents/MacOS
gdb firefox
run
*crash the app
bt full

* Include any useful additional information, steps you have tried, etc.:

This is Tenfourbird bug. But This may affect to TenFourFox (I think so...).

I've got report of crash bug from Tenfourbird users.
(See: https://sourceforge.jp/projects/tenfourbird/forums/28579/35080/ )

reported log is the following:
----BEGIN LOG----
Warning
Mozilla has caught an Obj-C exception [NSInvalidArgumentException: ***
-[ChildView drawRect:inTitlebarContext:]: unrecognized selector sent to 
instance 0x105cf550]

Error
*** -[ChildView drawRect:inTitlebarContext:]: unrecognized selector sent to 
instance 0x105cf550 
----END LOG----

The location of this bug is:
File:
 /widget/cocoa/nsCocoaWindow.mm
Function:
 static void ContentPatternDrawCallback(void* aInfo, CGContextRef aContext)
Line:
 3292
Code:
  [(ChildView*)view drawRect:titlebarRect inTitlebarContext:aContext];

[ChildView drawRect:inTitlebarContext:] has been deleted from mozilla-esr24 
repository.
( https://hg.mozilla.org/releases/mozilla-esr24/rev/3669991846ce )

What I should to do is:
modify it to [ChildView drawRect:inContext:] ?
should reimplement [ChildView drawRect:inTitlebarContext:] ?
or do other thing?

Your work (aka. TenFourFox) is incredible.
Tenfourbird is relying your great job.
Many many Thanks.

Original issue reported on code.google.com by t_mrc...@users.sourceforge.jp on 1 Jun 2014 at 10:33

GoogleCodeExporter commented 9 years ago 
I acknowledge the code bug, but after some analysis it doesn't appear this code 
ever actually gets executed in TenFourFox anymore. I'm surprised it does in 
Tenfourbird.

Because of how the titlebar drawing changes, I think changing it to 
drawRect:inContext: would probably be the best solution. If this works, I will 
carry the change forward.

Original comment by classi...@floodgap.com on 1 Jun 2014 at 3:47

GoogleCodeExporter commented 9 years ago 
Thank you for advice.

I've  uploaded Tenfourbird with the [drawRect:inContext:] patch.
http://sourceforge.jp/projects/tenfourbird/releases/61298/

There is a report that were worked fine.
http://sourceforge.jp/projects/tenfourbird/forums/28579/35080/73316/

But it is a mystery why did some Tenfourbird users reach that code....

Original comment by t_mrc...@users.sourceforge.jp on 7 Jun 2014 at 3:19

GoogleCodeExporter commented 9 years ago 
OK, that's good to hear. Unfortunately I'm already halfway through building the 
24.6.0 release candidates, so this change will not make that release, but I 
will put it into the 24.7.0 changesets and make sure I audit 31 for the same 
code block.

Was the user running any weird extensions or themes?

Original comment by classi...@floodgap.com on 7 Jun 2014 at 4:15

GoogleCodeExporter commented 9 years ago 
I forgot to ask about theme to them...

Original reporter was using ThunderBrowse and Enigmail.
2nd reporter was not using Enigmail.

I checked ThunderBrowse codes. (it's a very rough check...)
But I could not find codes that related to the titlebar.

I plan to include this patch in Tenfourbird 24.6.0.
Now I started preparing for the build.

I am looking forward to TenFourFox 31.

Thanks.

Original comment by t_mrc...@users.sourceforge.jp on 8 Jun 2014 at 3:43

GoogleCodeExporter commented 9 years ago 
Fixed in 31b and 24.7.

Original comment by classi...@floodgap.com on 16 Jul 2014 at 1:18