keeleysam / tenfourfox

Automatically exported from code.google.com/p/tenfourfox
0 stars 0 forks source link

Better fix for M665218? #82

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Discovered in the 6.0RC and confirmed by two users, see 
http://tenfourfox.blogspot.com/2011/08/tenfourfox-6-saved-by-sneakernet.html

10.5.8 prints normally. The test case in 665218 does not crash 10.4, so this 
appears to be the fix that broke it.

Decision for 6.0:
1) back it out, let it crash in those edge cases (the crash is not 
exploitable). Safest overall fix.
2) attempt a conditional fix now

For 7.0 we will definitely do 2).

Original issue reported on code.google.com by classi...@floodgap.com on 15 Aug 2011 at 4:14

GoogleCodeExporter commented 9 years ago
The test case does not seem to crash 10.5.8 either per rardin's report. Perhaps 
this bug is only in 10.6. So we will do 1) and only do 2) if needed.

Original comment by classi...@floodgap.com on 15 Aug 2011 at 4:16

GoogleCodeExporter commented 9 years ago
The test case doesn't crash 6.0RC/final on 10.5.8. It did crash 6.0b1 on 
10.5.8, though, but only the first time, and I haven't been able to reproduce 
the crash since.

Original comment by chtru...@web.de on 15 Aug 2011 at 4:34

GoogleCodeExporter commented 9 years ago
Backing out 665218 fixes printing which works on both 10.4 and .5.

Leaving open in case an alternate fix is needed.

Original comment by classi...@floodgap.com on 16 Aug 2011 at 4:11

GoogleCodeExporter commented 9 years ago
Dropping milestone, leaving open for tracking

Original comment by classi...@floodgap.com on 27 Sep 2011 at 4:23

GoogleCodeExporter commented 9 years ago
This may have been fixed in a unified manner by 
https://bug684622.bugzilla.mozilla.org/attachment.cgi?id=711995 -- need to 
check this for 21.

Original comment by classi...@floodgap.com on 13 Apr 2013 at 12:37

GoogleCodeExporter commented 9 years ago
It looks like it broke printing again. Doing a quick non-jemalloc build to make 
sure that's really what's going on.

Original comment by classi...@floodgap.com on 16 Apr 2013 at 5:14