this allows exports to work with characters which are not url-safe
What does this PR do? How does it affect users?
fixes csv export for content containing characters which are not url safe. We had titles in a table contain the # symbol making the whole file empty after the symbol. This corrects that issue.
Related tickets?
Didn't make an issue, just fixed it and submitted PR.
How should this be tested?
Export CSVs with various characters and confirm content is all exported.
Step through the code line by line. Things to keep in mind as you review:
Are there any edge cases not covered by this code?
Does this code follow conventions (naming, formatting, modularization, etc) where applicable?
Fetch the branch and/or deploy to staging to test the following:
[ ] Does the code compile without warnings (check shell, console)?
[ ] Do all tests pass?
[ ] Does the UI, pixel by pixel, look exactly as expected (check various screen sizes, including mobile)?
[ ] If the feature makes requests from the browser, inspect them in the Web Inspector. Do they look as expected (parameters, headers, etc)?
[ ] If the feature sends data to Keen, is the data visible in the project if you run an extraction (include link to collection/query)?
[ ] If the feature saves data to a database, can you confirm the data is indeed created in the database?
this allows exports to work with characters which are not url-safe
What does this PR do? How does it affect users?
fixes csv export for content containing characters which are not url safe. We had titles in a table contain the # symbol making the whole file empty after the symbol. This corrects that issue.
Related tickets?
Didn't make an issue, just fixed it and submitted PR.
How should this be tested?
Export CSVs with various characters and confirm content is all exported.
Step through the code line by line. Things to keep in mind as you review:
Fetch the branch and/or deploy to staging to test the following: