keen / keen-dataviz.js

Data Visualization Charting Library
MIT License
223 stars 49 forks source link

encode csv content #213

Closed todda00 closed 4 years ago

todda00 commented 4 years ago

this allows exports to work with characters which are not url-safe

What does this PR do? How does it affect users?

fixes csv export for content containing characters which are not url safe. We had titles in a table contain the # symbol making the whole file empty after the symbol. This corrects that issue.

Related tickets?

Didn't make an issue, just fixed it and submitted PR.

How should this be tested?

Export CSVs with various characters and confirm content is all exported.

Step through the code line by line. Things to keep in mind as you review:

Fetch the branch and/or deploy to staging to test the following:

maciejrybaniec commented 4 years ago

Hi @todda00 Thank You for the contribution. I'll test that changes tomorrow and prepare a release version.