'Library you selected does not support this chartType' in clean-viz

[dok]

Hey @aroc,

I ran the manual test in test/examples/visualize/index.html and the refactor seems to be causing some issues on selecting the chartType if the user does not specify it. My assumption is that none of those existing tests should be failing except for the intentional one. Could you take a look and let me know what you think? Thanks!

I've attached a screenshot with the stacktrace

[aroc]

@Dokko1230 Yep I'll take a look!

[aroc]

@Dokko1230 Seems to work as expected for me. Are you running the clean-viz branch and did you pull down any changes?

[dok]

@aroc Oh! Issues seem to be on my side. Simply forgot to turn on grunt watch..

Closing. Sorry about that :O

[dok]

Seems that the reason for this was that the trigger method for this.visual in _build_visual was taken out. And the merge did not successfully cover that scenario for me.. Weird.

https://github.com/keenlabs/keen-js/blob/clean-viz/src/visualize.js#L67

vs.

https://github.com/keenlabs/keen-js/blob/master/src/visualize.js#L81

[aroc]

@Dokko1230 I may have missed something when manually cherry-picking changes form master and merging them into the clean-viz branch. We can totally add that event triggering back in.

[dok]

Gotcha. I added it in the clean-viz branch to test it out. Once I add it, it errors with the same stacktrace for me.

Stacktrace:

[aroc]

@Dokko1230 How are you using the lib? When does the lack of that trigger call cause problems? I'm just trying to conceptualize a potential fix.

[dok]

I'm simply running code in index.html

It seems the issue seems to exist when this example is run. This error exists because the trigger method does not exist at this runtime for this.visual. Perhaps it is being overridden? Or maybe it is just not being extended to DataViz?

[aroc]

@Dokko1230 I don't think I'm understanding. You're just running the test/examples/visualize/index.html file? I can't replicate the error.

[dok]

Yep. I am just running that file.

Reproduction steps:

1. Checkout the clean-viz repository
2. On line 67 of visualize.js, add in the line

if (this.visual) {
      this.visual.trigger("remove");
 }

1. On chrome, refresh test/examples/visualize/index.html file

[aroc]

@Dokko1230 Oh ok, I didn't realize you added the line in order to get the error. To clarify, do you require the this.visual.trigger("remove"); code in the _build_visual function?

[dok]

Yes that is correct.

if (this.visual) {
  this.visual.trigger("remove");
}

[aroc]

Ok cool. I'll find some time today to look into how to bring that back.

[aroc]

@Dokko1230 Ok, I think this should be working now on the clean-viz branch. Let me know if you have any other issues.

[dok]

Looks fixed. Thanks!