search

keenlabs / KeenClient-Java

Official Java client for the Keen IO API. Build analytics features directly into your Java apps.
https://keen.io/docs
MIT License
74 stars 43 forks source link

add support for proxy servers #13

Closed ryber closed 7 years ago

ryber commented 10 years ago

This resolves issue #12 and adds support for HTTP proxy servers in the Keen IO client.

A couple of notes: 1) It does not support authenticated proxies. users can set the authenticator on their own 2) It currently only supports HTTP proxies (this is the vast majority of users) 3) Not setting the proxy does not block configuring a container level one.

A note on code: I picked constructor injection to get the proxy into KeenHttpRequestRunnable. This was a personal preference. If you would rather I directly reference the static config at the point where it is used I can change it.

olensmar commented 10 years ago

any ideas on when this will be available in an official build?

dkador commented 10 years ago

We're getting v2 (see the branch if you're interested) merged to master soon, then we'll swing back to this.

josephwegner commented 7 years ago

I'm going to close this. It's been stale for a long time. I will open a new issue with the goal of achieving this same thing, but I think the code is so old it'll be more work than starting from scratch.