keenlabs / KeenClient-Java

Official Java client for the Keen IO API. Build analytics features directly into your Java apps.
https://keen.io/docs
MIT License
74 stars 43 forks source link

Add logging behaviour description to README.md #26

Closed jstanier closed 9 years ago

jstanier commented 9 years ago

Give an example of how to turn logging on, and also how to enable debug mode.

I've put this PR in after @PeterNachbaur and @wetzler helped me work out via email why Exceptions weren't being thrown. I thought it might be useful to anyone else who has the same problem.

jstanier commented 9 years ago

Let me know if you'd rather this be somewhere else in the file - I thought this area looked best...

Geeber commented 9 years ago

Thanks for the PR! There's one slight correction to make (see my comment). You've already done plenty though so if you'd like I can just merge this and then edit it in master. Or you can edit the PR. Just let me know :)

jstanier commented 9 years ago

No worries - I'll edit the PR, no problem.

Geeber commented 9 years ago

Awesome, we really appreciate you taking the time to make this clearer for everyone else.

jstanier commented 9 years ago

I've just made the changes and rebased the PR - hopefully that's good enough.

Geeber commented 9 years ago

Looks great, thanks again! Merged.

jstanier commented 9 years ago

:+1: