keenlabs / KeenClient-Java

Official Java client for the Keen IO API. Build analytics features directly into your Java apps.
https://keen.io/docs
MIT License
74 stars 43 forks source link

Option to disable the KeenClient's log handler #33

Closed mikereinhold closed 9 years ago

mikereinhold commented 9 years ago

The KeenClient for java registers its own log handler to publish logs to System.out. It would be useful to have a clean way to disable this default handler to meet application needs.

For instance, some applications may prefer to have Keen log to a file and reserve System.out for warning or error messages.

I would suggest additions to the KeenLogging class to allow the application to disable the default handler that is registered by Keen. If you feel that this would be valuable, I can put together a PR for this.

joshed-io commented 9 years ago

I think that's a great idea. Very willing to entertain a PR :)

mikereinhold commented 9 years ago

Sounds good - I'll get to work on this one and the others that I've recently commented on.

joshed-io commented 9 years ago

Awesome. Thanks Mike!

On Monday, December 8, 2014 at 1:27 PM, Mike Reinhold wrote:

Sounds good - I'll get to work on this one and the others that I've recently commented on.

— Reply to this email directly or view it on GitHub (https://github.com/keenlabs/KeenClient-Java/issues/33#issuecomment-66190395).