search

keenlabs / KeenClient-Java

Official Java client for the Keen IO API. Build analytics features directly into your Java apps.
https://keen.io/docs
MIT License
74 stars 43 forks source link

Extension of KeenCallback interface to support callback execution with detailed information #35

Closed mikereinhold closed 9 years ago

mikereinhold commented 9 years ago

Added an extension to the KeenCallback interface to support callbacks which require additional information in order to perform the necessary activity.

This implementation assumes that the both callback methods should be called for each event (if the callback is an instance of the KeenDetailedCallback interface). This implementation calls the KeenCallback callback method first, then the KeenDetailedCallback callback method afterward.

Closes issue #32.

joshed-io commented 9 years ago

Awesome! Will check this out tomorrow.

joshed-io commented 9 years ago

Looks good to me. @Geeber eyes?

Geeber commented 9 years ago

Looks good to me as well. Could you do me a favor and submit the pull request to the 2.1.0 branch? https://github.com/keenlabs/KeenClient-Java/tree/2.1.0 Then I'll go ahead and merge it in. We should be releasing 2.1.0 within the next week, or definitely by the end of the month.

mikereinhold commented 9 years ago

Ok cool. I'll close this PR and reopen against the 2.1.0 branch. Thanks!