keenlabs / KeenClient-PHP

Official PHP client for the Keen IO API. Build analytics features directly into your PHP apps.
https://keen.io/docs
MIT License
133 stars 57 forks source link

Adds access key service descriptions #104

Closed deweller closed 7 years ago

jaketoolson commented 7 years ago

Any updates on adding this!?

tbarn commented 7 years ago

@mglaman wanna update your review?

tbarn commented 7 years ago

Thanks, @mglaman! ✨ 💖

@deweller I'd feel more comfortable merging this if docs were added to the readme. Think you could add some?

Some examples are: https://keen.io/docs/api/?javascript#access-keys Also, this one isn't complete, but definitely a good start: https://github.com/keenlabs/keen-gem#access-keys

deweller commented 7 years ago

I've abandoned this pull request. But you are welcome to use the code if you find it helpful.

mglaman commented 7 years ago

I am also not actively using the SDK or this PR patch anymore to push forward changes. Took too long for feedback and activity from Keen.

tbarn commented 7 years ago

@deweller @mglaman totally understandable. And I apologize for how long it took for movement on this. I'm going to be working on improving this in the future for all our SDKs.