search

keenlabs / KeenClient-PHP

Official PHP client for the Keen IO API. Build analytics features directly into your PHP apps.
https://keen.io/docs
MIT License
133 stars 57 forks source link

Use Openssl rather than MCrypt to encrypt scoped keys #113

Closed stof closed 7 years ago

stof commented 7 years ago

MCrypt is deprecated as of PHP 7.1. Closes #108

The new tests I added are here to ensure that the algorithm can decrypt keys generated by the previous mcrypt-based algorithm rather than just its own encrypted key. The ideal test would be a test encryption a key in the library, and then ensuring that the Keen.io backend logic can actually decrypt it (as this is what is important for usage of the SDK). But writing such test is much harder (it would require the CI to be able to run the keen.io backend crypto logic.

stof commented 7 years ago

@josephwegner is there any chance to get this merged ?

stof commented 7 years ago

@baumatron what is the next step to get this merged and released now ?

tbarn commented 7 years ago

hey @stof - checking in with the team on this! sorry about the delay! I think we were checking to make sure people had the correct permissions to cut a new version.

stof commented 7 years ago

@baumatron could you make a new release ?