search

keenlabs / KeenClient-PHP

Official PHP client for the Keen IO API. Build analytics features directly into your PHP apps.
https://keen.io/docs
MIT License
133 stars 57 forks source link

PSR2 Standards #116

Closed simondotwhite closed 7 years ago

simondotwhite commented 7 years ago

Hey, I noticed some of the package isn't fully compatible with PSR2 coding standards.

Would this be something worth considering for Hacktoberfest?

tbarn commented 7 years ago

Hey @Sekonda! Thanks for this issue! I'm down to consider it for Hacktoberfest. I'll add the label now.

arjank commented 7 years ago

Shouldn't be too difficult. Working on it.

tbarn commented 7 years ago

Hey @arjank, @Sekonda already has a PR #117 opened for this issue. There might need to be some work done in the docs for it, but it is mostly complete.

arjank commented 7 years ago

I only saw your comment and the PR when I was about to commit my changes. I also made the test files PSR2 compliant (with only minor changes) and I'll commit and create a PR anyway.