search

keenlabs / KeenClient-Python

Official Python client for the Keen IO API. Build analytics features directly into your Python apps.
https://keen.io/docs
MIT License
133 stars 58 forks source link

Relax requirements on requests #133

Closed arnaudlimbourg closed 7 years ago

arnaudlimbourg commented 7 years ago

Hello,

Would it be possible to relax the requirements on the requests package. I've been experimenting with pipenv which usespip-tools and complains when there is a mismatch in the dependencies:

pipdeptree -r -p requests                                                                         
Warning!!! Possibly conflicting dependencies found:
* keen==0.4.0
 - requests [required: >=2.5,<2.11.0, installed: 2.18.4]
------------------------------------------------------------------------

I've been using the keen library with an up-to-date requests for a while and there does not seem to be any issue (granted it's not a scientific approach).

Would it be okay to have >=2.5,<3 as a version requirement?

masojus commented 7 years ago

I believe this is addressed in PR #132 as part of fixing Issue #129

arnaudlimbourg commented 7 years ago

Indeed I had missed that, great!