search

keenlabs / KeenClient-Python

Official Python client for the Keen IO API. Build analytics features directly into your Python apps.
https://keen.io/docs
MIT License
133 stars 58 forks source link

Loosen dependencies requirement #148

Closed arnaudlimbourg closed 5 years ago

arnaudlimbourg commented 6 years ago

Hello,

Using pipenv ton install this client there is a versioning issue regarding six.

Currently, requirements.txt specifies six ~=1.10.0 which fails if 1.11.0 is installed. Usually six requirement is a minimum version but not as strict.

Could you loosen it to >=1.10?

masojus commented 6 years ago

Both #147 and #149 aim to fix this. For six I think we could go with ~=1.10 which would pick up any 1.*.* >= 1.10.0--that should work whether your have/need 1.10 or 1.11 in your environment.

ChristopherHammond13 commented 5 years ago

Bump: is this issue still being looked at? It's a simple fix but it would be great to have it upstream to remove our pip install warnings that we still have in production. Thanks so much!

arnaudlimbourg commented 5 years ago

I ended forking it for as it pipenv would not work otherwise :)

masojus commented 5 years ago

This is fixed with PR #151